all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>, Stefan Lendl <s.lendl@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH v3 proxmox-backup 0/3] datastore: Create a prune job upon datastore creation
Date: Fri, 24 Nov 2023 12:20:59 +0100	[thread overview]
Message-ID: <ff0c1450-07cd-470a-90a4-a7133cc81609@proxmox.com> (raw)
In-Reply-To: <20231123163840.454705-2-s.lendl@proxmox.com>

Am 23/11/2023 um 17:38 schrieb Stefan Lendl:
> prune-schedule was availible as an option in API and GUI but had no effect
> because datastore prunes are handles by prune-jobs.
> This creates a default prune job if prune-schedule is set when creating the
> datastore.
> 
> Differences to v2->v3:
>   updated Option.and_then() to Option.map()
>   Added Tested-by g.goller trailer

Please add new trailers (how git calls those metadata lines at the end) always
at the end, i.e., those should only grow downwards and your S-o-b should stay
the top one.

> 
> Differences to v1->v2:
>   split into individual patches to separatly move logic to do_create_prune_job
> 
> Stefan Lendl (3):
>   prune job: prune job creation in separate function
>   pass worker context to do_create_prune_job
>   fix #4374: create a prune job upon datastore creation
> 
>  src/api2/config/datastore.rs | 49 +++++++++++++++++++++++++++++-------
>  src/api2/config/prune.rs     | 43 ++++++++++++++++++++-----------
>  2 files changed, 68 insertions(+), 24 deletions(-)
> 


applied series, with Lukas' R-b and T-b added, thanks!




      parent reply	other threads:[~2023-11-24 11:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-23 16:38 [pbs-devel] " Stefan Lendl
2023-11-23 16:38 ` [pbs-devel] [PATCH v3 proxmox-backup 1/3] prune job: prune job creation in separate function Stefan Lendl
2023-11-23 16:38 ` [pbs-devel] [PATCH v3 proxmox-backup 2/3] pass worker context to do_create_prune_job Stefan Lendl
2023-11-23 16:38 ` [pbs-devel] [PATCH v3 proxmox-backup 3/3] fix #4374: create a prune job upon datastore creation Stefan Lendl
2023-11-24  8:50 ` [pbs-devel] [PATCH v3 proxmox-backup 0/3] datastore: Create " Lukas Wagner
2023-11-24 11:20 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff0c1450-07cd-470a-90a4-a7133cc81609@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=s.lendl@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal