From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api 0/2] fix clusterjoin with ssh-keys !=2048 bits
Date: Wed, 14 Jul 2021 18:02:43 +0200 [thread overview]
Message-ID: <fdf01146-904e-cb33-f745-98c3e2c5080c@proxmox.com> (raw)
In-Reply-To: <20210714144430.241822-1-s.ivanov@proxmox.com>
On 14.07.21 16:44, Stoiko Ivanov wrote:
> currently it's not possible to join a PMG cluster if the joining node (or
> its root user) has a ssh-rsa key larger (or !=2048 bits)
>
> noticed the glitch while trying to join a PMG container based on
> debian-bullseye.
>
> mid-term I'd like to also allow for other key-formats (ed25519) to work, but
> since this needs a bit more work it can be postponed.
>
or drop using ssh completely ;-)
> tested the patches on the same container (joining was successful)
>
> Stoiko Ivanov (2):
> cluster: refactor ssh pubkey verification
> cluster: add '=' to ssh pubkey pattern
>
> src/PMG/Cluster.pm | 5 +++--
> src/PMG/ClusterConfig.pm | 8 ++++++--
> 2 files changed, 9 insertions(+), 4 deletions(-)
>
applied both patches, added the missing space in the return statement and suffixed
the method name with the _regex
prev parent reply other threads:[~2021-07-14 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 14:44 Stoiko Ivanov
2021-07-14 14:44 ` [pmg-devel] [PATCH pmg-api 1/2] cluster: refactor ssh pubkey verification Stoiko Ivanov
2021-07-14 14:44 ` [pmg-devel] [PATCH pmg-api 2/2] cluster: add '=' to ssh pubkey pattern Stoiko Ivanov
2021-07-14 16:02 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdf01146-904e-cb33-f745-98c3e2c5080c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.