From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Kefu Chai <k.chai@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH v2 proxmox-acme 3/3] buildsys: run tests as part of dpkg-buildpackage
Date: Tue, 31 Mar 2026 18:16:13 +0200 [thread overview]
Message-ID: <fda13d5e-f689-473c-aa37-66c110781017@proxmox.com> (raw)
In-Reply-To: <20260331071041.1199091-4-k.chai@proxmox.com>
Am 31.03.26 um 09:10 schrieb Kefu Chai:
> Add override_dh_auto_test to debian/rules so that make test is
> automatically executed during every package build, ensuring the
> schema and Makefile consistency checks are enforced at build time.
This already happens though? dh_auto_test will already trigger any
"check" or "test" target if there's a Makefile present, and when
building a package without your patch here I can see that working.
Or am I missing something here?
>
> Signed-off-by: Kefu Chai <k.chai@proxmox.com>
> ---
> debian/rules | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/debian/rules b/debian/rules
> index f00dbc2..2118ffa 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -5,3 +5,6 @@
>
> %:
> dh $@
> +
> +override_dh_auto_test:
> + $(MAKE) -C . -f Makefile test
next prev parent reply other threads:[~2026-03-31 16:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 7:10 [PATCH v2 proxmox-acme 0/3] update acme.sh DNS API to upstream 3.1.2 tag Kefu Chai
2026-03-31 7:10 ` [PATCH v2 proxmox-acme 1/3] " Kefu Chai
2026-03-31 7:10 ` [PATCH v2 proxmox-acme 2/3] tests: verify all dnsapi plugins are listed in Makefile ACME_SOURCES Kefu Chai
2026-03-31 7:10 ` [PATCH v2 proxmox-acme 3/3] buildsys: run tests as part of dpkg-buildpackage Kefu Chai
2026-03-31 16:16 ` Thomas Lamprecht [this message]
2026-04-01 4:31 ` Kefu Chai
2026-03-31 16:48 ` applied: [PATCH v2 proxmox-acme 0/3] update acme.sh DNS API to upstream 3.1.2 tag Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fda13d5e-f689-473c-aa37-66c110781017@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=k.chai@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.