From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [PATCH container] destroy: remove pending volumes as well
Date: Thu, 30 Sep 2021 17:40:07 +0200 [thread overview]
Message-ID: <fd601a23-9466-eaf9-35aa-2c23c3574755@proxmox.com> (raw)
In-Reply-To: <20210929094507.1566495-1-f.gruenbichler@proxmox.com>
On 29.09.21 11:45, Fabian Grünbichler wrote:
> if a volume is only referenced in the pending section of a config it was
> previously not removed when removing the CT, unless the non-default
> 'remove unreferenced disks' option was enabled.
>
> keeping track of volume IDs which we attempt to remove gets rid of false
> warnings in case a volume is referenced both in the config and the
> pending section, or multiple times in the config for other reasons.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> src/PVE/LXC.pm | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2021-09-30 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 9:45 [pve-devel] " Fabian Grünbichler
2021-09-29 9:45 ` [pve-devel] [PATCH qemu-server] vm_destroy: " Fabian Grünbichler
2021-09-30 15:40 ` [pve-devel] applied: " Thomas Lamprecht
2021-09-30 15:40 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd601a23-9466-eaf9-35aa-2c23c3574755@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal