Re: [pve-devel] [PATCH qemu-server 1/1] create_vm: assume HA state 'started' when live-restoring guests

From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Fiona Ebner" <f.ebner@proxmox.com>,
	"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Michael Köppl" <m.koeppl@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 1/1] create_vm: assume HA state 'started' when live-restoring guests
Date: Fri, 21 Nov 2025 11:24:27 +0100	[thread overview]
Message-ID: <fc22c242-fbaa-4654-9b80-be2c278688e6@proxmox.com> (raw)
In-Reply-To: <3b73cb50-9f26-42be-85a9-8ce2886407c8@proxmox.com>

Am 21.11.25 um 11:15 schrieb Fiona Ebner:
> Am 21.11.25 um 11:04 AM schrieb Thomas Lamprecht:
>> We lock the config on restore, or?
>> If so, couldn't we handle this in the HA stack and do not shutdown if a
>> restore lock is present in the config?
> 
> But that'd be more coupling? Further below in the endpoint we have (two
> instances of):

Making the HA actually aware of how the resources it manages work, so that
it can make better decisions, is definitively not more coupling.

> 
>>             if ($ha_managed) {
>>                 print "Add as HA resource\n";
>>                 my $state = $start_after_create ? 'started' : 'stopped';
>>                 my $cmd = ['ha-manager', 'add', "vm:$vmid", '--state', $state];
>>                 eval { PVE::Tools::run_command($cmd); };
>>                 warn $@ if $@;
>>             }
> 
> So we could just put $start_after_create || $live_restore there

Does not solves the case for when restores over a existing VM that is a HA
resource already, FWICT.

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel