Re: [PATCH pve-manager v2 2/4] fix #6464: vzdump: add retry strategies for failed guest backups

[Jonas Theisen <j.theisen@proxmox.com>]

On 11/11/26 10:35, Jakob Klocker wrote:
> <snip>
>
> diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
> index 56d2aea3..e4aa303d 100644
> --- a/PVE/VZDump.pm
> +++ b/PVE/VZDump.pm
> @@ -10,6 +10,7 @@ use File::Path;
>   use IO::File;
>   use IO::Select;
>   use IPC::Open3;
> +use List::Util qw(min);
>   use POSIX qw(strftime);
>   use Time::Local;
>   
> @@ -1048,7 +1049,8 @@ sub exec_backup_task {
>           -d $task->{tmpdir}
>               || die "unable to create temporary directory '$task->{tmpdir}'";
>   
> -        $logfd = IO::File->new(">$tmplog")
> +        my $logmode = $task->{retries} ? '>>' : '>';
> +        $logfd = IO::File->new("${logmode}${tmplog}")

In case the first backup run fails before opening its backup log
the retry's log gets appended to an older previous log file.
Maybe cleanup the $tmplog once per job to avoid appending
to a remaining log file?
>               || die "unable to create log file '$tmplog'";
>   
>           $task->{dumpdir} = $opts->{dumpdir};
>
> <snip>