From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id 4B7111FF0B3
	for <inbox@lore.proxmox.com>; Wed, 11 Nov 2026 16:41:00 +0100 (CET)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 7D46921627;
	Wed, 11 Nov 2026 16:40:56 +0100 (CET)
Message-ID: <fbe9e088-4fb8-4fc2-a24d-560138268e2a@proxmox.com>
Date: Wed, 11 Nov 2026 16:40:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH pve-manager v2 2/4] fix #6464: vzdump: add retry
 strategies for failed guest backups
To: Jakob Klocker <j.klocker@proxmox.com>, pve-devel@lists.proxmox.com
References: <20261111093407.109872-1-j.klocker@proxmox.com>
 <20261111093407.109872-3-j.klocker@proxmox.com>
Content-Language: en-US
From: Jonas Theisen <j.theisen@proxmox.com>
In-Reply-To: <20261111093407.109872-3-j.klocker@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1794411653050
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.093 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: FH2DMV7BSN4ZUIVZVKYXXDFGXWYF5CI2
X-Message-ID-Hash: FH2DMV7BSN4ZUIVZVKYXXDFGXWYF5CI2
X-MailFrom: j.theisen@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On 11/11/26 10:35, Jakob Klocker wrote:
> <snip>
>
> diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
> index 56d2aea3..e4aa303d 100644
> --- a/PVE/VZDump.pm
> +++ b/PVE/VZDump.pm
> @@ -10,6 +10,7 @@ use File::Path;
>   use IO::File;
>   use IO::Select;
>   use IPC::Open3;
> +use List::Util qw(min);
>   use POSIX qw(strftime);
>   use Time::Local;
>   
> @@ -1048,7 +1049,8 @@ sub exec_backup_task {
>           -d $task->{tmpdir}
>               || die "unable to create temporary directory '$task->{tmpdir}'";
>   
> -        $logfd = IO::File->new(">$tmplog")
> +        my $logmode = $task->{retries} ? '>>' : '>';
> +        $logfd = IO::File->new("${logmode}${tmplog}")

In case the first backup run fails before opening its backup log
the retry's log gets appended to an older previous log file.
Maybe cleanup the $tmplog once per job to avoid appending
to a remaining log file?
>               || die "unable to create log file '$tmplog'";
>   
>           $task->{dumpdir} = $opts->{dumpdir};
>
> <snip>