From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: PVE development discussion <pve-devel@pve.proxmox.com>,
Mira Limbeck <m.limbeck@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v2] change icmp type selector to a combogrid
Date: Wed, 16 Mar 2022 15:23:51 +0100 [thread overview]
Message-ID: <fbb178d6-9bc8-3e2b-9d7f-61865adcb42d@proxmox.com> (raw)
In-Reply-To: <20200529122206.31787-3-m.limbeck@proxmox.com>
On 29.05.20 14:22, Mira Limbeck wrote:
> The combogrid contains all valid icmp types that iptables accepts. In
> addition to the names, the Type[/Code] value is shown as well. But
> specifying Type[/Code] is not supported.
>
> As the simple solution with setStore() does not work to change the store
> for the combogrid, we simply have 2 different ICMPTypeSelectors, one for
> IPv4, the other for IPv6, which are switched depending on the specified
> protocol.
>
> As disabled fields don't submit their value, we can keep the values for
> the dport and both icmp-type fields when switching protocols.
>
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> ---
> v2:
> - rebased on master
> - removed unnecessary name switching and removing of values on proto
> switch
>
> www/manager6/grid/FirewallRules.js | 164 ++++++++++++++++++++++++++++-
> 1 file changed, 160 insertions(+), 4 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2022-03-16 14:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200529122206.31787-1-m.limbeck@proxmox.com>
2020-09-09 18:56 ` [pve-devel] applied: [PATCH v2 firewall] introduce new icmp-type parameter Thomas Lamprecht
[not found] ` <20200529122206.31787-2-m.limbeck@proxmox.com>
2022-03-16 14:23 ` [pve-devel] applied: [PATCH v2 docs] add documentation for the " Thomas Lamprecht
[not found] ` <20200529122206.31787-3-m.limbeck@proxmox.com>
2022-03-16 14:23 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbb178d6-9bc8-3e2b-9d7f-61865adcb42d@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.limbeck@proxmox.com \
--cc=pve-devel@pve.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal