Re: [PATCH proxmox-backup v2 4/5] ui: datastore: disable remove action for namespaces

[Dominik Csapak <d.csapak@proxmox.com>]

On 5/6/26 2:12 PM, Erik Fastermann wrote:
> Disable the remove action and tooltip for namespaces.

nit: a short 'why' would improve the commit message here
for example:

Since the namespace entry does not show a remove button,
also disable the action itself and hide the tooltip.

> 
> Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
> ---
> 
>   changes since v1:
>   * cleaned up boolean logic
> 
>   www/datastore/Content.js | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/www/datastore/Content.js b/www/datastore/Content.js
> index cb0159a51..576e70a59 100644
> --- a/www/datastore/Content.js
> +++ b/www/datastore/Content.js
> @@ -1211,7 +1211,13 @@ Ext.define('PBS.DataStoreContent', {
>                           data.ty === 'dir'
>                               ? 'fa critical fa-trash-o'
>                               : 'pmx-hidden',
> -                    isActionDisabled: (v, r, c, i, { data }) => false,
> +                    isActionDisabled: (v, r, c, i, { data }) => {
> +                        const enabled =
> +                            (data.ty === 'ns' && !data.isRootNS && data.ns === undefined) ||
> +                            data.ty === 'group' ||
> +                            data.ty === 'dir';
> +                        return !enabled;
> +                    },
>                   },
>                   {
>                       handler: 'downloadFile',