Re: [PATCH proxmox-backup v2 2/5] ui: datastore: fix content search empty list

[Dominik Csapak <d.csapak@proxmox.com>]

two things here:

in general it would be good that the commit message explains why
the code does something (done here) but also explain any
non-obvious relation to the code (i.e. how does the change
have this effect)

i say this because to me it's not super obvious how this change
can have this effect. I looked at the surrounding code a bit
and IMO this part should not even be called when one clears
the search (since we should return early in that case before
the setTimeout)

so i think the real fix is probably something else and the
fact that this change fixes it for you is probably just a
side effect...

On 5/6/26 2:11 PM, Erik Fastermann wrote:
> Display items again when searching by a non existing value and
> clearing the search bar.
> 
> Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
> ---
>   www/datastore/Content.js | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/www/datastore/Content.js b/www/datastore/Content.js
> index e963d62f9..54e93bd3c 100644
> --- a/www/datastore/Content.js
> +++ b/www/datastore/Content.js
> @@ -961,7 +961,6 @@ Ext.define('PBS.DataStoreContent', {
>               // we do it a little bit later for the error mask to work
>               setTimeout(function () {
>                   store.clearFilter();
> -                store.getRoot().collapseChildren(true);
>   
>                   store.beginUpdate();
>                   store.getRoot().cascadeBy({