From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit] node: repos: Use won't rather than don't
Date: Fri, 24 Nov 2023 17:08:56 +0100 [thread overview]
Message-ID: <fb2964ac-f824-434c-97a5-0892bad087ec@proxmox.com> (raw)
In-Reply-To: <9c20a776-1477-4510-a0c5-9563ee10b8c1@proxmox.com>
Am 24.11.23 um 16:41 schrieb Lukas Wagner:
>
>
> On 11/24/23 15:58, Maximiliano Sandoval wrote:
>> - Ext.String.format(gettext('No {0} repository is enabled,
>> you do not get any updates!'), vm.get('product')),
>> + Ext.String.format(gettext('No {0} repository is enabled,
>> you would not get any updates!'), vm.get('product')),
>
> The long form of won't is 'will not', not 'would not'. 'will not' also
> seems more appropriate here.
>
Both wordings are correct, just a different tense
You do not get any updates (i.e. right now)
You will not get any updates (i.e. in the future)
Is there a good reason for changing it in the first place? Should be
mentioned in the commit message then ;)
prev parent reply other threads:[~2023-11-24 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 14:58 Maximiliano Sandoval
2023-11-24 15:33 ` Dietmar Maurer
2023-11-24 15:41 ` Lukas Wagner
2023-11-24 16:08 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb2964ac-f824-434c-97a5-0892bad087ec@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.