From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Filip Schauer <f.schauer@proxmox.com>
Subject: Re: [pve-devel] [PATCH container] fix #5160: fix move_mount regression for mount point hotplug
Date: Mon, 25 Mar 2024 11:49:51 +0100 [thread overview]
Message-ID: <f9bfbaa2-ac90-41b9-ab7a-a58bf91f1eb0@proxmox.com> (raw)
In-Reply-To: <bdbbcc46-6fb1-48fc-94fd-7b2359684ce9@proxmox.com>
Am 25.03.24 um 11:29 schrieb Fiona Ebner:
>
> After shutdown+start, the hotplug worked as expected. Played around a
> bit more and something strange happened with LVM as the storage: While
> it worked the first time, when I shut down the container, detached the
> mount point, started again and then tried to hot-plug, I got:
> mp1: unable to hotplug mp1: command 'mount /dev/lvm/vm-129-disk-1
> /var/lib/lxc/.pve-staged-mounts/mp1' failed: exit code 32
>
> Doesn't seem to happen with ZFS or directory storage and starting with
> the mount point pre-attached also worked fine with previously written
> files still there.
>
> Also booted into 6.2.16-20-pve, installed unpatched pve-container and it
> seems the issue was already present then.
>
After looking into this, it's likely because the LV is deactivated after
the shutdown. Apparently we're missing the activate_volume() call before
doing a hotplug.
next prev parent reply other threads:[~2024-03-25 10:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 13:54 Filip Schauer
2024-03-25 10:29 ` Fiona Ebner
2024-03-25 10:49 ` Fiona Ebner [this message]
2024-03-25 17:30 ` Filip Schauer
2024-03-25 17:31 ` Filip Schauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9bfbaa2-ac90-41b9-ab7a-a58bf91f1eb0@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal