Re: [pdm-devel] [PATCH datacenter-manager v3 0/9] implement more complex search syntax

[Stefan Hanreich <s.hanreich@proxmox.com>]

Changes to the code LGTM!

Did another quick test of this patch series on my machine by clicking on
all the elements on the dashboard and adding some custom search terms /
conditions:

Only small thing I noticed is that when clicking on Remotes, the
singular search term still isn't required. Could easily be done in a
follow-up imo.

Consider this:

Reviewed-by: Stefan Hanreich <s.hanreich@proxmox.com>
Tested-by: Stefan Hanreich <s.hanreich@proxmox.com>


On 8/26/25 2:34 PM, Dominik Csapak wrote:
> this introduces a more complex search syntax for the resources api call
> and uses that with the dashboard to show relevant resources, e.g.
> when clicking on the remotes panel when there are failed remotes, it
> adds a search to the box that filters for offline remotes. Same
> for clicking on the running vm count, etc.
> 
> The syntax is a first draft of mine, we can still tweak and change it
> as we see fit, but it's a start.
> 
> a 'normal' search term gets filtered to id/name so that does not change
> as before, but you can now specify 'categories' with `category:value`
> e.g. it's now possible to search for `type:remote` or `status:offline`
> 
> it also adds the possibility to mark terms as required like this:
> 
> +someterm
> 
> required terms have to exist in the resulting resource, while optional
> ones are OR'd (so at least one optional match must exist)
> 
> Not implemented yet are (but can be done afterwards):
> * GUI for filtering
> * Include subscription status
> * negation of terms (this get's complicated fast ;) )
> 
> changes from v2:
> * incorporated stefans feedback for FromIterator, Default, etc.
> * added tests for the 'matches' function
> * add required search term for the guest 'All' text
> 
> changes from v1:
> * added commit to improve text width
> * added commit to add clear trigger to search box
> * rebased on master
> 
> Dominik Csapak (9):
>   pdm-api-types: resources: add helper methods for fields
>   lib: add pdm-search crate
>   server: api: resources: add more complex filter syntax
>   ui: add possibility to insert into search box
>   ui: dashboard: remotes panel: open search on click
>   ui: dashboard: guest panel: search for guest states when clicking on
>     them
>   ui: dashboard: search for nodes when clicking on the nodes panel
>   ui: search box: add clear trigger
>   ui: dashboard: guest panel: improve column widths
> 
>  Cargo.toml                        |   2 +
>  lib/pdm-api-types/src/resource.rs |  27 +++
>  lib/pdm-search/Cargo.toml         |  12 ++
>  lib/pdm-search/src/lib.rs         | 282 ++++++++++++++++++++++++++++++
>  server/Cargo.toml                 |   1 +
>  server/src/api/resources.rs       |  80 +++++++--
>  ui/Cargo.toml                     |   1 +
>  ui/src/dashboard/guest_panel.rs   |  84 ++++++++-
>  ui/src/dashboard/mod.rs           |  46 ++++-
>  ui/src/dashboard/remote_panel.rs  |  32 +++-
>  ui/src/lib.rs                     |   3 +
>  ui/src/main.rs                    |  17 +-
>  ui/src/search_provider.rs         |  35 ++++
>  ui/src/widget/search_box.rs       |  40 ++++-
>  14 files changed, 629 insertions(+), 33 deletions(-)
>  create mode 100644 lib/pdm-search/Cargo.toml
>  create mode 100644 lib/pdm-search/src/lib.rs
>  create mode 100644 ui/src/search_provider.rs
> 



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel