From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
"Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup] pbs-manager: fix pull not respecting local ns setting
Date: Tue, 20 Sep 2022 12:48:55 +0200 [thread overview]
Message-ID: <f971daf9-28be-ecfa-f1e5-df766af5100e@proxmox.com> (raw)
In-Reply-To: <1663670523.a17unliena.astroid@nora.none>
Am 20/09/2022 um 12:43 schrieb Fabian Grünbichler:
> On September 20, 2022 12:24 pm, Thomas Lamprecht wrote:
>> Am 20/09/2022 um 12:19 schrieb Fabian Grünbichler:
>>> thanks for the quick fix!
>>
>> You were quicker (I wanted to amend the commit message a bit) and currently
>> wondering why that POST call went through anyway, as the extra unknown
>> parameter should cause a higher level error?
>
> I was looking in parallel based on the forum report and then saw the
> patch coming in ;)
>
> the API defaults to (silently) allowing additional properties, which is
> why this is neither an error nor logged anywhere. this behaviour comes
> from PVE IIRC.
That normally should require a explicit `additional_properties: true,` which
we do not set here. The ObjectSchema has it set to false by default and PVE's
default is also false IIRC, resulting in a 400 error..
next prev parent reply other threads:[~2022-09-20 10:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 10:08 [pbs-devel] " Matthias Heiserer
2022-09-20 10:19 ` [pbs-devel] applied: " Fabian Grünbichler
2022-09-20 10:24 ` Thomas Lamprecht
2022-09-20 10:43 ` Fabian Grünbichler
2022-09-20 10:48 ` Thomas Lamprecht [this message]
2022-09-20 11:18 ` Fabian Grünbichler
2022-09-20 11:21 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f971daf9-28be-ecfa-f1e5-df766af5100e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal