all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Hannes Laimer <h.laimer@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH v2 pve-manager 0/2] add bulk suspend
Date: Mon, 13 Nov 2023 14:25:02 +0100	[thread overview]
Message-ID: <f957c7df-0ca3-4167-997b-7ca2c78598e3@proxmox.com> (raw)
In-Reply-To: <20231113102046.303005-1-h.laimer@proxmox.com>

Am 13/11/2023 um 11:20 schrieb Hannes Laimer:
> Adds support for bulk suspending VMs as it already exists for stop.
> 
> v2, thanks @Thomas:
> * api: skip CTs + fix permission checks
> * ui: disable `suspendall` button if user isn;t allowed to use it
> * ui: use new bulk action filtering
> 
> Hannes Laimer (2):
>   api: add suspendall endpoint
>   ui: add bulk suspend support
> 
>  PVE/API2/Nodes.pm                 | 124 ++++++++++++++++++++++++++++++
>  www/manager6/Utils.js             |   1 +
>  www/manager6/node/CmdMenu.js      |  15 ++++
>  www/manager6/node/Config.js       |  14 ++++
>  www/manager6/window/BulkAction.js |   5 +-
>  5 files changed, 157 insertions(+), 2 deletions(-)
> 


applied series, thanks!

I made the "passed VMID of a CT" case use log_warn though, so it's more
visible that something odd was requested.

And UX style wise it could be nicer if we have "fixed" filters for the
store, as currently one can easily hit the "Clear Filters" button and
then can select all CTs (or stopped VMs) without any hint that suspension
for these won't work.

But it's not a biggie and did not want to block on that, so just for the
record that we can probably improve on this.




      parent reply	other threads:[~2023-11-13 13:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-13 10:20 [pve-devel] " Hannes Laimer
2023-11-13 10:20 ` [pve-devel] [PATCH v2 pve-manager 1/2] api: add suspendall endpoint Hannes Laimer
2023-11-13 10:20 ` [pve-devel] [PATCH v2 pve-manager 2/2] ui: add bulk suspend support Hannes Laimer
2023-11-13 13:25 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f957c7df-0ca3-4167-997b-7ca2c78598e3@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=h.laimer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal