Re: [pbs-devel] [PATCH proxmox-backup] verify: include namespace for group in log

[Hannes Laimer <h.laimer@proxmox.com>]

On 11/20/25 14:09, Fabian Grünbichler wrote:
> On November 20, 2025 12:52 pm, Hannes Laimer wrote:
>> Groups with the same name in different namespaces couldn't really be told
>> appart. This solves this by also printing the namespace of a group to the
>> log.
>>
>> This came up in support.
>>
>> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
>> ---
>> not super sure about the formatting, didn't want to change the
>> <datastore>:<group> format we use a lot. don't log for snapshots as that
>> would potentially add a lot of output that doesn't add much information
>>
>>   src/backup/verify.rs | 9 ++++++++-
>>   1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/backup/verify.rs b/src/backup/verify.rs
>> index 734c7b30..10f54c28 100644
>> --- a/src/backup/verify.rs
>> +++ b/src/backup/verify.rs
>> @@ -500,8 +500,15 @@ impl VerifyWorker {
>>           };
>>   
>>           let snapshot_count = list.len();
>> +        let ns = group.backup_ns();
>> +        let ns_str = if ns.is_root() {
>> +            "/".to_string()
>> +        } else {
>> +            ns.to_string()
>> +        };
>>           info!(
>> -            "verify group {}:{} ({} snapshots)",
>> +            "verify group in '{}' - {}:{} ({} snapshots)",
>> +            ns_str,
> 
> when syncing, we log the namespace once at the start/end, should follow
> this approach here as well for consistency?
> 
> nested namespace names can get quite long..
> 

IIRC we sort just by the groups, but if the namespaces would be done in
blocks, sure. would cut down verbosity by quite a bit



>>               self.datastore.name(),
>>               group.group(),
>>               snapshot_count
>> -- 
>> 2.47.3
>>
>>
>>
>> _______________________________________________
>> pbs-devel mailing list
>> pbs-devel@lists.proxmox.com
>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>>
>>
>>
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel