From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit
Date: Mon, 15 Apr 2024 15:10:31 +0200 [thread overview]
Message-ID: <f92fb753-a4da-42d6-9697-7e9da41895dd@proxmox.com> (raw)
In-Reply-To: <20240223120339.15726-1-h.laimer@proxmox.com>
Am 23.02.24 um 13:03 schrieb Hannes Laimer:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> came up in enterprise support, and I don't think there is a reason to
> not have it in the UI, while having it in the API
>
This rationale could/should become the commit message, i.e. the fact
that having it in the UI is convenient for many users.
The plugin for BTRFS also supports this option. I think it makes sense
adding it there too. Could even be done in storage/Base.js like for
preallocation, but as long as there is no third plugin with the option,
duplication is also fine IMHO.
next prev parent reply other threads:[~2024-04-15 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 12:03 Hannes Laimer
2024-04-15 13:10 ` Fiona Ebner [this message]
2024-04-15 14:02 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f92fb753-a4da-42d6-9697-7e9da41895dd@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.