Re: [pbs-devel] [PATCH v3 proxmox 1/4] http: client: make https connector generic over resolver

From: Christian Ebner <c.ebner@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH v3 proxmox 1/4] http: client: make https connector generic over resolver
Date: Tue, 8 Apr 2025 16:21:30 +0200	[thread overview]
Message-ID: <f8dbd4bc-294c-47e8-9ecc-923ee548cf44@proxmox.com> (raw)
In-Reply-To: <e72lwy5ajpmvq36hqo4egzvbg47i5wu3o7amehtitw7myu3ryv@xvhz2igtj3iw>

On 4/8/25 16:06, Wolfgang Bumiller wrote:
> One tiny nit...
> 
> On Tue, Apr 08, 2025 at 02:38:08PM +0200, Christian Ebner wrote:
>>   
>>   #[derive(Clone)]
>> -pub struct HttpsConnector {
>> -    connector: HttpConnector,
>> +pub struct HttpsConnector<T> {
> 
> Generics on structs can have defaults, so if we use
> 
>      struct HttpsConnctor<T = GaiResolver> {}
> 
> then even the old pbs code builds.
> While it is *still* technically a breaking change, other users of this
> crate *likely* can do with just a dependency bump.
> 
> (But at least it *sort of* documents what the heck this `T` is supposed
> to be on a type otherwise completely devoid of documentation ;-) )

A great! Will add the default type for the generic and add the docs as 
requested by Lukas in the other response.

_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel