From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH v3 proxmox-widget-toolbox 4/9] safe-destroy: add possibility to show a small note
Date: Fri, 11 Sep 2020 13:08:06 +0200 [thread overview]
Message-ID: <f8a6a481-f4e8-d279-d9d7-9c58aced6ac4@proxmox.com> (raw)
In-Reply-To: <20200828084658.22057-5-h.laimer@proxmox.com>
comment inline
On 8/28/20 10:46 AM, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> add field to set the note and add ui-container for displaying it
>
> src/window/SafeDestroy.js | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/src/window/SafeDestroy.js b/src/window/SafeDestroy.js
> index a6ad458..0027e98 100644
> --- a/src/window/SafeDestroy.js
> +++ b/src/window/SafeDestroy.js
> @@ -21,6 +21,7 @@ Ext.define('Proxmox.window.SafeDestroy', {
> purgeable: false,
> },
> url: undefined,
> + note: undefined,
> taskName: undefined,
> params: {},
> },
> @@ -138,6 +139,22 @@ Ext.define('Proxmox.window.SafeDestroy', {
> 'data-qtip': gettext('Remove from replication and backup jobs'),
> },
> },
> + {
> + xtype: 'container',
> + reference: 'noteContainer',
> + flex: 1,
> + layout: {
> + type: 'vbox',
> + align: 'middle',
> + },
> + height: 25,
> + items: [
> + {
> + xtype: 'component',
> + reference: 'noteCmp',
> + },
> + ],
> + },
2 things here:
* if i have a very long message, it gets truncated and
is not completely visible anymore. since we often
have that text in a 'gettext' where we do not often
check for the length, this could be a problem
* i would set it to hidden by default
> ],
> },
> ],
> @@ -161,8 +178,17 @@ Ext.define('Proxmox.window.SafeDestroy', {
> }
>
> const messageCmp = me.lookupReference('messageCmp');
> + const noteCmp = me.lookupReference('noteCmp');
> let msg;
>
> + if (Ext.isDefined(me.getNote())) {
> + noteCmp.setHtml(`<small>${me.getNote()}</small>`);
> + } else {
> + const noteContainer = me.lookupReference('noteContainer');
> + noteContainer.setDisabled(true);
> + noteContainer.setHidden(true);
> + }
and here only make it visible if getNote is defined.
this makes the code a litte more compact
e.g.
let note = me.getNote();
if (Ext.isDefined(note)) {
...setHtml...
...setHidden(false)...
}
> +
> if (Ext.isDefined(me.getTaskName())) {
> msg = Proxmox.Utils.format_task_description(me.getTaskName(), item.id);
> messageCmp.setHtml(msg);
>
next prev parent reply other threads:[~2020-09-11 11:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 8:46 [pve-devel] [PATCH v3 proxmox-widget-toolbox 0/9] removal of directories in PBS WebUI Hannes Laimer
2020-08-28 8:46 ` [pbs-devel] " Hannes Laimer
2020-08-28 8:46 ` [pve-devel] [PATCH v3 proxmox-widget-toolbox 1/9] safe-destroy: move SafeDestroy from pve-manager here Hannes Laimer
2020-08-28 8:46 ` [pbs-devel] " Hannes Laimer
2020-09-11 11:07 ` Dominik Csapak
2020-08-28 8:46 ` [pve-devel] [PATCH v3 proxmox-widget-toolbox 2/9] safe-destroy: replace type with purgeable and taskName Hannes Laimer
2020-08-28 8:46 ` [pbs-devel] " Hannes Laimer
2020-08-28 8:46 ` [pve-devel] [PATCH v3 proxmox-widget-toolbox 3/9] safe-destroy: replace var with let/const Hannes Laimer
2020-08-28 8:46 ` [pbs-devel] " Hannes Laimer
2020-08-28 8:46 ` [pve-devel] [PATCH v3 proxmox-widget-toolbox 4/9] safe-destroy: add possibility to show a small note Hannes Laimer
2020-08-28 8:46 ` [pbs-devel] " Hannes Laimer
2020-09-11 11:08 ` Dominik Csapak [this message]
2020-08-28 8:46 ` [pve-devel] [PATCH v3 pve-manager 5/9] safe-destroy: use SafeDestroy from proxmox-widget-toolkit Hannes Laimer
2020-08-28 8:46 ` [pbs-devel] " Hannes Laimer
2020-08-28 8:46 ` [pve-devel] [PATCH v3 pve-manager 6/9] remove SafeDestroy from pve-manager Hannes Laimer
2020-08-28 8:46 ` [pbs-devel] " Hannes Laimer
2020-08-28 8:46 ` [pve-devel] [PATCH v3 proxmox-widget-toolbox 7/9] utils: add task description for directory removal Hannes Laimer
2020-08-28 8:46 ` [pbs-devel] " Hannes Laimer
2020-08-28 8:46 ` [pve-devel] [PATCH v3 proxmox-backup 8/9] api2: add name of mount-point to DatastoreMountInfo Hannes Laimer
2020-08-28 8:46 ` [pbs-devel] " Hannes Laimer
2020-09-11 11:08 ` Dominik Csapak
2020-08-28 8:46 ` [pve-devel] [PATCH v3 proxmox-backup 9/9] ui: add remove-button for directories/mount-units Hannes Laimer
2020-08-28 8:46 ` [pbs-devel] " Hannes Laimer
2020-09-11 11:08 ` Dominik Csapak
2020-09-11 11:07 ` [pbs-devel] [PATCH v3 proxmox-widget-toolbox 0/9] removal of directories in PBS WebUI Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8a6a481-f4e8-d279-d9d7-9c58aced6ac4@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal