all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager 2/2] configs: vzdump: add notes-template default
Date: Mon, 9 May 2022 09:46:22 +0200	[thread overview]
Message-ID: <f857eb8f-42af-603f-c96c-681bc0c19636@proxmox.com> (raw)
In-Reply-To: <20220509071733.23055-2-f.ebner@proxmox.com>

Am 09.05.22 um 09:17 schrieb Fabian Ebner:
> so users can see that it can be configured here.
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> Causes a "configuration changed by distributor" dialogue when
> upgrading the package.
> 
>  configs/vzdump.conf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/vzdump.conf b/configs/vzdump.conf
> index a0075cfa..fe4b18ab 100644
> --- a/configs/vzdump.conf
> +++ b/configs/vzdump.conf
> @@ -14,3 +14,4 @@
>  #script: FILENAME
>  #exclude-path: PATHLIST
>  #pigz: N
> +#notes-template: {{guestname}}

There's a cosmetic issue here. I get
parse error in '/etc/vzdump.conf' - 'storage': missing property -
'notes-template' requires this property
if notes-template is configured, but storage isn't. It still works, but
is very misleading. I'll work out a v2.




  reply	other threads:[~2022-05-09  7:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09  7:17 [pve-devel] [PATCH manager 1/2] ui: manual backup: also set " Fabian Ebner
2022-05-09  7:17 ` [pve-devel] [PATCH manager 2/2] configs: vzdump: add " Fabian Ebner
2022-05-09  7:46   ` Fabian Ebner [this message]
2022-05-09 11:52   ` Thomas Lamprecht
2022-05-10  6:59     ` Fabian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f857eb8f-42af-603f-c96c-681bc0c19636@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal