[pve-devel] [PATCH qemu] build: drop explicit libproxmox-backup-qemu0 dep

[pve-devel] [PATCH qemu] build: drop explicit libproxmox-backup-qemu0 dep

[Fabian Grünbichler]

it ships a symbol file now, so it can be auto-generated based on the
build-dep and usage.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
WARNING: this needs a version of libproxmox-backup-qemu0 with symbols
files in the build deps, otherwise the generated dependency will become
an unversioned one based on just the SO version..

 debian/control | 1 -
 1 file changed, 1 deletion(-)

diff --git a/debian/control b/debian/control
index ee913e8..b182c45 100644
--- a/debian/control
+++ b/debian/control
@@ -52,7 +52,6 @@ Depends: ceph-common (>= 0.48),
          libiscsi4 (>= 1.12.0) | libiscsi7,
          libjemalloc2,
          libjpeg62-turbo,
-         libproxmox-backup-qemu0 (>= 1.0.2-1),
          libsdl1.2debian,
          libspice-server1 (>= 0.14.0~),
          libusb-1.0-0 (>= 1.0.17-1),
-- 
2.20.1

[pve-devel] [PATCH proxmox-backup-qemu] build: track symbols

[Fabian Grünbichler]

for easier auto-generation of versioned deps. when adding new symbols,
the build should display a warning + diff (in addition to our manual
tracking of the generated header file). changes in symbol signatures or
semantics are not caught automatically by the symbols file, but still
require bumping the minimum library version for that symbol accordingly.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
this reflects the current state in master - the masterkey patch changes
proxmox_backup_new to 1.0.3 or whatever the post-bump version is..

 debian/libproxmox-backup-qemu0.symbols | 34 ++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 debian/libproxmox-backup-qemu0.symbols

diff --git a/debian/libproxmox-backup-qemu0.symbols b/debian/libproxmox-backup-qemu0.symbols
new file mode 100644
index 0000000..603235a
--- /dev/null
+++ b/debian/libproxmox-backup-qemu0.symbols
@@ -0,0 +1,34 @@
+libproxmox_backup_qemu.so.0 libproxmox-backup-qemu0 #MINVER#
+ proxmox_backup_abort@Base 1.0.0
+ proxmox_backup_add_config@Base 1.0.0
+ proxmox_backup_add_config_async@Base 1.0.0
+ proxmox_backup_check_incremental@Base 1.0.0
+ proxmox_backup_close_image@Base 1.0.0
+ proxmox_backup_close_image_async@Base 1.0.0
+ proxmox_backup_connect@Base 1.0.0
+ proxmox_backup_connect_async@Base 1.0.0
+ proxmox_backup_disconnect@Base 1.0.0
+ proxmox_backup_finish@Base 1.0.0
+ proxmox_backup_finish_async@Base 1.0.0
+ proxmox_backup_free_error@Base 1.0.0
+ proxmox_backup_new@Base 1.0.0
+ proxmox_backup_qemu_version@Base 1.0.2
+ proxmox_backup_register_image@Base 1.0.0
+ proxmox_backup_register_image_async@Base 1.0.0
+ proxmox_backup_snapshot_string@Base 1.0.0
+ proxmox_backup_write_data@Base 1.0.0
+ proxmox_backup_write_data_async@Base 1.0.0
+ proxmox_export_state@Base 1.0.0
+ proxmox_free_state_buf@Base 1.0.0
+ proxmox_import_state@Base 1.0.0
+ proxmox_restore_connect@Base 1.0.0
+ proxmox_restore_connect_async@Base 1.0.0
+ proxmox_restore_disconnect@Base 1.0.0
+ proxmox_restore_get_image_length@Base 1.0.0
+ proxmox_restore_image@Base 1.0.0
+ proxmox_restore_new@Base 1.0.0
+ proxmox_restore_open_image@Base 1.0.0
+ proxmox_restore_open_image_async@Base 1.0.0
+ proxmox_restore_read_image_at@Base 1.0.0
+ proxmox_restore_read_image_at_async@Base 1.0.0
+ (optional)rust_eh_personality@Base 1.0.0
-- 
2.20.1

[pve-devel] applied: [PATCH proxmox-backup-qemu] build: track symbols

[Thomas Lamprecht]

On 09.02.21 12:29, Fabian Grünbichler wrote:
> for easier auto-generation of versioned deps. when adding new symbols,
> the build should display a warning + diff (in addition to our manual
> tracking of the generated header file). changes in symbol signatures or
> semantics are not caught automatically by the symbols file, but still
> require bumping the minimum library version for that symbol accordingly.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> this reflects the current state in master - the masterkey patch changes
> proxmox_backup_new to 1.0.3 or whatever the post-bump version is..

done 

> 
>  debian/libproxmox-backup-qemu0.symbols | 34 ++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>  create mode 100644 debian/libproxmox-backup-qemu0.symbols
> 
>

applied, thanks!

[pve-devel] applied: [PATCH qemu] build: drop explicit libproxmox-backup-qemu0 dep

[Thomas Lamprecht]

On 09.02.21 12:29, Fabian Grünbichler wrote:
> it ships a symbol file now, so it can be auto-generated based on the
> build-dep and usage.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> WARNING: this needs a version of libproxmox-backup-qemu0 with symbols
> files in the build deps, otherwise the generated dependency will become
> an unversioned one based on just the SO version..
> 
>  debian/control | 1 -
>  1 file changed, 1 deletion(-)
> 
>

applied but squashed in the build-dependency version update for
libproxmox-backup-qemu0-dev, thanks!