all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH installer] gui: make abort button focusable
@ 2023-06-21 10:02 Maximiliano Sandoval
  2023-06-21 10:36 ` Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Maximiliano Sandoval @ 2023-06-21 10:02 UTC (permalink / raw)
  To: pve-devel

GtkWiget:can-focus=false means that the user cannot use tab or key
navigation to interact with this button.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxinstall | 1 -
 1 file changed, 1 deletion(-)

diff --git a/proxinstall b/proxinstall
index 6d13892..f260a95 100755
--- a/proxinstall
+++ b/proxinstall
@@ -178,7 +178,6 @@ sub create_main_window {
 
 
     my $abort = Gtk3::Button->new('_Abort');
-    $abort->set_can_focus(0);
     $cmdbox->pack_start($abort, 0, 0, 10);
     $abort->signal_connect(clicked => sub { app_quit(-1); });
 
-- 
2.39.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [pve-devel] [PATCH installer] gui: make abort button focusable
  2023-06-21 10:02 [pve-devel] [PATCH installer] gui: make abort button focusable Maximiliano Sandoval
@ 2023-06-21 10:36 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-06-21 10:36 UTC (permalink / raw)
  To: Proxmox VE development discussion, Maximiliano Sandoval

Am 21/06/2023 um 12:02 schrieb Maximiliano Sandoval:
> GtkWiget:can-focus=false means that the user cannot use tab or key
> navigation to interact with this button.
> 

that's not true, as Do the Alt + A combination works just fine here.
And not having it in the default focusing "group" is definitively wanted.

I'd rather keep it as is.

> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  proxinstall | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/proxinstall b/proxinstall
> index 6d13892..f260a95 100755
> --- a/proxinstall
> +++ b/proxinstall
> @@ -178,7 +178,6 @@ sub create_main_window {
>  
>  
>      my $abort = Gtk3::Button->new('_Abort');
> -    $abort->set_can_focus(0);
>      $cmdbox->pack_start($abort, 0, 0, 10);
>      $abort->signal_connect(clicked => sub { app_quit(-1); });
>  





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-21 10:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-21 10:02 [pve-devel] [PATCH installer] gui: make abort button focusable Maximiliano Sandoval
2023-06-21 10:36 ` Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal