all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH installer] gui: make abort button focusable
Date: Wed, 21 Jun 2023 12:36:32 +0200	[thread overview]
Message-ID: <f7ffd638-fe8a-d6b2-d538-601d7bc66c58@proxmox.com> (raw)
In-Reply-To: <20230621100251.57126-1-m.sandoval@proxmox.com>

Am 21/06/2023 um 12:02 schrieb Maximiliano Sandoval:
> GtkWiget:can-focus=false means that the user cannot use tab or key
> navigation to interact with this button.
> 

that's not true, as Do the Alt + A combination works just fine here.
And not having it in the default focusing "group" is definitively wanted.

I'd rather keep it as is.

> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  proxinstall | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/proxinstall b/proxinstall
> index 6d13892..f260a95 100755
> --- a/proxinstall
> +++ b/proxinstall
> @@ -178,7 +178,6 @@ sub create_main_window {
>  
>  
>      my $abort = Gtk3::Button->new('_Abort');
> -    $abort->set_can_focus(0);
>      $cmdbox->pack_start($abort, 0, 0, 10);
>      $abort->signal_connect(clicked => sub { app_quit(-1); });
>  





      reply	other threads:[~2023-06-21 10:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 10:02 Maximiliano Sandoval
2023-06-21 10:36 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7ffd638-fe8a-d6b2-d538-601d7bc66c58@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal