From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [RFC PATCH pve-manager 1/2] ui: mobile: fix totp login
Date: Tue, 23 Apr 2024 16:40:56 +0200 [thread overview]
Message-ID: <f7d49e5f-0a3a-4972-ad68-e5d4e9560dd3@proxmox.com> (raw)
In-Reply-To: <20231214095517.2339898-1-d.csapak@proxmox.com>
Am 14/12/2023 um 10:55 schrieb Dominik Csapak:
> logging in with totp on mobile was broken with these two commits:
>
> pve-manager:
> 509d7a20 ("mobile ui: implement dummy message box and scrip loader")
> and
> pve-access-control:
> cb64967 ("api: drop old verify_tfa api call")
>
> the pve-manager one overwrote the Ext.MessageBox and Ext.Msg classes and
> thus removed the Ext.MessageBox.OKCANCEL constant that represented the
> buttons of popup messages (without those no buttons on message boxes
> where shown).
>
> This override did not work as intended, as we still showed the message
> box by accident, because at that point the Ext.MessageBox was already
> initialized (so it was overwritten), but Ext.Msg was not (this happens
> later).
>
> and the pve-access-control removed the old tfa verify api (which is now
> done via the /access/ticket api)
>
> so to fix that, we have to adapt to the api changes and restore the
> stock Ext.MessageBox and Ext.Msg classes by removing the overrides
> (i couldn't find where we would need those)
>
> we still cannot handle u2f or recovery methods though
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/mobile/Login.js | 8 ++++++--
> www/mobile/Toolkit.js | 5 -----
> 2 files changed, 6 insertions(+), 7 deletions(-)
>
>
applied both patches, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-04-23 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 9:55 [pve-devel] " Dominik Csapak
2023-12-14 9:55 ` [pve-devel] [RFC PATCH pve-manager 2/2] ui: mobile: enable subscription popup Dominik Csapak
2024-04-23 14:40 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7d49e5f-0a3a-4972-ad68-e5d4e9560dd3@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.