From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: Re: [PATCH container] setup/debian: use cidr for buster and newer
Date: Sat, 11 Jul 2020 17:25:41 +0200 [thread overview]
Message-ID: <f7b33b8e-a905-521d-98c7-7294308cd943@proxmox.com> (raw)
In-Reply-To: <20200710164334.23819-1-s.ivanov@proxmox.com>
On 10.07.20 18:43, Stoiko Ivanov wrote:
> starting with version 0.8.35 of ifupdown (shipped currently with buster)
> the configuration using a separate 'netmask' line instead of providing the
> cidr in the 'address' line of a interface stanza of /etc/network/interfaces
> is deprecated.
>
> This means that some software installed on newer debian versions, which
> parses /etc/network/interfaces may not support the format currently written
> by PVE::LXC::Setup::Debian::setup_network.
>
> This patch changes the content of the generated file to use the newer format
> only for newer versions of debian (alpine, older ubuntu versions and devuan
> also rely on the sub to generate the network config)
>
> caught by installing proxmox-backup-server on a debian buster container and
> getting a parse-error in the network configuration tab in the GUI.
>
> tested by creating a ubuntu-14.04, debian-6, debian-8 and a debian-10
> container and checking the resulting /etc/network/interfaces.
>
> [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=912220
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> src/PVE/LXC/Setup/Debian.pm | 19 ++++++++++++++-----
> 1 file changed, 14 insertions(+), 5 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2020-07-11 15:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 16:43 [pve-devel] " Stoiko Ivanov
2020-07-11 15:25 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7b33b8e-a905-521d-98c7-7294308cd943@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal