From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [RFC qemu-server] fix #2862: properly backup (all) VM templates
Date: Fri, 21 Aug 2020 14:13:27 +0200 [thread overview]
Message-ID: <f768797b-473a-a53e-f00f-4ba3bed0ad59@proxmox.com> (raw)
In-Reply-To: <20200806111349.67063-1-f.gruenbichler@proxmox.com>
On 06.08.20 13:13, Fabian Grünbichler wrote:
> until we maybe have a 'pbs-backup' that links Qemu and PBS like
> 'pbs-restore', we need to do a regular backup for the template case to
> support all storage types and image formats.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>
> Notes:
> requires patched pve-qemu to drop read-only check
>
> alternatively, we could also start writing a pbs-backup (or a
> general pbs-qemu ?) soon, and just disable PBS template backups in
> the meantime.
>
> PVE/QemuServer.pm | 6 +++++-
> PVE/VZDump/QemuServer.pm | 22 +++++++---------------
> 2 files changed, 12 insertions(+), 16 deletions(-)
>
>
While not 100% happy with this, it works OK from what I can see. And we highly
probably won't write a pbs-backup wrapper just for this use-case.
applied, thanks!
prev parent reply other threads:[~2020-08-21 12:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 11:13 [pve-devel] " Fabian Grünbichler
2020-08-06 11:13 ` [pve-devel] [RFC qemu] allow backup of read-only block drives Fabian Grünbichler
2020-08-20 12:35 ` [pve-devel] applied: " Thomas Lamprecht
2020-08-21 12:13 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f768797b-473a-a53e-f00f-4ba3bed0ad59@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.