all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] vm_destroy: remove pending volumes as well
Date: Thu, 30 Sep 2021 17:40:13 +0200	[thread overview]
Message-ID: <f7301da6-d53a-332a-acda-a98c01bd2e77@proxmox.com> (raw)
In-Reply-To: <20210929094507.1566495-2-f.gruenbichler@proxmox.com>

On 29.09.21 11:45, Fabian Grünbichler wrote:
> if a volume is only referenced in the pending section of a config it was
> previously not removed when removing the VM, unless the non-default
> 'remove unreferenced disks' option was enabled.
> 
> keeping track of volume IDs which we attempt to remove gets rid of false
> warnings in case a volume is referenced both in the config and the
> pending section, or multiple times in the config for other reasons.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>  PVE/QemuServer.pm | 5 +++++
>  1 file changed, 5 insertions(+)
> 
>

applied, thanks!




  reply	other threads:[~2021-09-30 15:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29  9:45 [pve-devel] [PATCH container] destroy: " Fabian Grünbichler
2021-09-29  9:45 ` [pve-devel] [PATCH qemu-server] vm_destroy: " Fabian Grünbichler
2021-09-30 15:40   ` Thomas Lamprecht [this message]
2021-09-30 15:40 ` [pve-devel] applied: [PATCH container] destroy: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7301da6-d53a-332a-acda-a98c01bd2e77@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal