all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Yew framework devel list at Proxmox <yew-devel@lists.proxmox.com>,
	Shan Shaji <s.shaji@proxmox.com>
Subject: Re: [yew-devel] [PATCH proxmox-yew-comp] fix: use IEC standared for showing the HD space
Date: Mon, 9 Mar 2026 22:22:44 +0100	[thread overview]
Message-ID: <f6937586-a9be-4a98-8510-2a8aad688c16@proxmox.com> (raw)
In-Reply-To: <20251219172031.288936-1-s.shaji@proxmox.com>

Am 19.12.25 um 18:21 schrieb Shan Shaji:
> The HD space was being showing in SI unit, However all other metrics
> shown in the remote overview section were in IEC unit. Fixed it by
> updating it to use the IEC unit.

But we do favor base-10 units for storage sizes and IEC for memory (and
bits for network traffic), so this would seem alright as is to me, or?

> 
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>  src/node_info.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/node_info.rs b/src/node_info.rs
> index 0f8fcb5..ca656d0 100644
> --- a/src/node_info.rs
> +++ b/src/node_info.rs
> @@ -204,8 +204,8 @@ pub fn node_info(data: Option<NodeStatus>) -> Container {
>                  .status(format!(
>                      "{:.2}% ({} of {})",
>                      fraction * 100.0,
> -                    HumanByte::new_decimal(root_used as f64),
> -                    HumanByte::new_decimal(root_total as f64),
> +                    HumanByte::from(root_used),
> +                    HumanByte::from(root_total),
>                  ))
>          })
>          .with_child({





  reply	other threads:[~2026-03-09 21:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-19 17:20 Shan Shaji
2026-03-09 21:22 ` Thomas Lamprecht [this message]
2026-03-10  9:02   ` Shan Shaji
2026-03-10  9:27     ` Shan Shaji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6937586-a9be-4a98-8510-2a8aad688c16@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=s.shaji@proxmox.com \
    --cc=yew-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal