From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Oguz Bektas <o.bektas@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] pvereport: get pressure stall information
Date: Tue, 11 May 2021 17:31:52 +0200 [thread overview]
Message-ID: <f5d5a75b-b0b2-6ac0-eedd-7942fa6abfbd@proxmox.com> (raw)
In-Reply-To: <20210511110400.241153-1-o.bektas@proxmox.com>
On 11.05.21 13:04, Oguz Bektas wrote:
> PSI can be queried in /proc/pressure/{cpu,io,memory} for the
> corresponding resources. this helps us track down disruptions caused
> by resource overcommitment.
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> PVE/Report.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied, thanks! But the inserted order felt a bit weird to me, I found it
fitting better below the `top` command a few commands above, but looking at
the whole report module I found that it was due for some refactoring anyway,
so as follow-up I:
* got rid of all those ugly side-effects we relied on
* made the definition hash the single source of info, dropping the extra
order array, which was always a bit weird
* split out the top and PSI into a new "system-load" section
* adding some stderr output about what's going on in dir2text
if something is off with my followups just shout.
prev parent reply other threads:[~2021-05-11 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 11:04 [pve-devel] " Oguz Bektas
2021-05-11 15:31 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5d5a75b-b0b2-6ac0-eedd-7942fa6abfbd@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.