all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: qemu disk: honor iothread setting from config
Date: Mon, 21 Nov 2022 15:57:02 +0100	[thread overview]
Message-ID: <f4dcb186-a47d-cdd1-1547-33bbf17a0345@proxmox.com> (raw)
In-Reply-To: <20221121143906.195079-1-d.csapak@proxmox.com>

Am 21/11/2022 um 15:39 schrieb Dominik Csapak:
> to have a iothread on by default in the wizard and on disk add, we
> added a 'bind' for the value here. This also changes the value
> for existing vm disks, and if one does not notice, modifies it
> away again (since we don't have the controller here and isSCSISingle is
> false)
> 
> simply don't bind value when we edit a vm disk from config
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/manager6/qemu/HDEdit.js | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
>

applied, thanks! for the record: this wasn't an issue in Firefox.




      reply	other threads:[~2022-11-21 14:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21 14:39 [pve-devel] " Dominik Csapak
2022-11-21 14:57 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4dcb186-a47d-cdd1-1547-33bbf17a0345@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal