all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes with Yes/No text
Date: Mon, 23 Jan 2023 12:01:41 +0100	[thread overview]
Message-ID: <f4d665f0-9fb9-1761-f82c-43373c58b046@proxmox.com> (raw)
In-Reply-To: <dc077dc9-8530-a96f-c661-b45b433e4e1e@proxmox.com>



On 1/23/23 11:57, Thomas Lamprecht wrote:
> Ok, tbh. I have some faint memory that I saw some comment about this in the
> distant past; IIRC it was mostly due to the the "writeable" firewall and the
> "read-only" other usages using both the exact same display.
> 
My bad, there actually was a report about this, Leo kindly showed me the entry in Bugzilla just now [1].

>>
>> I have played around a bit with FA icons, and I think I have found something that is visually
>> appealing, fixed-width and where it is IMO clear that it is not an actionable UI item.
>> For now, I think the nicest option is `fa-check` for enabled rows and `fa-minus` for disabled ones.
>> I've created an A:B comparison [1] between the old checkboxes and the new icons.
>> Please let me know what you think.
>>
> 
> looks better than the status quo, especially UX-wise, and would be an option for
> icon only. So, if nobody else has hard feelings (but ideally somewhat rationally
> argued) for going with text over icon I'd go for your combination check-mark/minus
> icon combination.
> 

Ok great, then I'll post a v2 with the icon-version soon.

Thanks!

[1] https://bugzilla.proxmox.com/show_bug.cgi?id=4350

-- 
- Lukas




      reply	other threads:[~2023-01-23 11:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20 11:17 Lukas Wagner
2023-01-20 11:17 ` [pve-devel] [PATCH manager 1/2] ui: backup: replication: replace non-clickable checkbox " Lukas Wagner
2023-01-20 11:17 ` [pve-devel] [PATCH widget-toolkit 2/2] repo view: " Lukas Wagner
2023-01-20 14:09 ` [pve-devel] [PATCH manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes " Thomas Lamprecht
2023-01-23 10:46   ` Lukas Wagner
2023-01-23 10:57     ` Thomas Lamprecht
2023-01-23 11:01       ` Lukas Wagner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4d665f0-9fb9-1761-f82c-43373c58b046@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal