all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] fix #5528: override cgroup methods to call systemd via dbus
Date: Wed, 24 Jul 2024 14:26:43 +0200	[thread overview]
Message-ID: <f4bbbd64-584f-44e2-b39e-90e6515d53d8@proxmox.com> (raw)
In-Reply-To: <20240709091025.148010-1-w.bumiller@proxmox.com>

Am 09/07/2024 um 11:10 schrieb Wolfgang Bumiller:
> Systemd reapplies its known values on reload, so we cannot simply call
> into PVE::CGroup. Call systemd's SetUnitProperties method via dbus
> instead.
> 
> The hotplug and startup code also calculated different values, as one
> operated within systemd's value framework (documented in
> systemd.resource-control(5)) and one worked with cgroup values
> (distinguishing between cgroup v1 and v2 manually).
> 
> This is now unified by overriding `change_cpu_quota()` and
> `change_cpu_shares()` via `PVE::QemuServer::CGroup` which now takes
> systemd-based values and sends those directly via dbus.
> 
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
>  PVE/QemuServer.pm        |  4 ++--
>  PVE/QemuServer/CGroup.pm | 51 +++++++++++++++++++++++++++++++++++++++-
>  2 files changed, 52 insertions(+), 3 deletions(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2024-07-24 12:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-09  9:10 [pve-devel] " Wolfgang Bumiller
2024-07-24 12:26 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4bbbd64-584f-44e2-b39e-90e6515d53d8@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal