From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Shan Shaji <s.shaji@proxmox.com>
Subject: [pve-devel] partially applied: [PATCH pve_flutter_frontend 0/4] fix: add fix for dart-analyze issues and replace deprecated APIs
Date: Fri, 26 Sep 2025 11:25:23 +0200 [thread overview]
Message-ID: <f48a3b2f-67ae-43d5-affe-720290319026@proxmox.com> (raw)
In-Reply-To: <20250924103625.144589-1-s.shaji@proxmox.com>
On 9/24/25 12:36 PM, Shan Shaji wrote:
> After upgrading to Flutter v3.35, the dart analyze command reported
> several issues. This patch series resolves them by applying `dart fix`
> to automatically correct issues where possible. For cases where
> automated fixes were not available, I manually replaced deprecated
> APIs and addressed linting errors.
>
> Shan Shaji (4):
> fix: run `dart fix` to fix the problems identified by diagnostic
> cleanup: dart-analyze: add explicit type annotation
> fix: dart-analyze: remove deprecated props and use `RadioGroup`
> chore: add upper bound flutter constraint and update dart sdk
> constraint
>
> lib/main.dart | 4 ++--
> lib/pages/main_layout_slim.dart | 5 ++++-
> lib/utils/validators.dart | 8 ++++----
> lib/widgets/pve_bridge_selector_widget.dart | 2 +-
> lib/widgets/pve_cd_selector_widget.dart | 13 +++++--------
> lib/widgets/pve_guest_backup_widget.dart | 4 ++--
> lib/widgets/pve_guest_migrate_widget.dart | 2 +-
> lib/widgets/pve_guest_os_selector_widget.dart | 2 +-
> lib/widgets/pve_network_model_selector.dart | 2 +-
> lib/widgets/pve_storage_selector_widget.dart | 2 +-
> lib/widgets/pve_task_log_widget.dart | 2 +-
> pubspec.lock | 2 +-
> pubspec.yaml | 3 ++-
> 13 files changed, 26 insertions(+), 25 deletions(-)
>
applied the first 3 patches, see my comment on the 4th for details, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-09-26 9:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 10:36 [pve-devel] " Shan Shaji
2025-09-24 10:36 ` [pve-devel] [PATCH pve_flutter_frontend 1/4] fix: run `dart fix` to fix the problems identified by diagnostic Shan Shaji
2025-09-24 10:36 ` [pve-devel] [PATCH pve_flutter_frontend 2/4] cleanup: dart-analyze: add explicit type annotation Shan Shaji
2025-09-24 10:36 ` [pve-devel] [PATCH pve_flutter_frontend 3/4] fix: dart-analyze: remove deprecated props and use `RadioGroup` Shan Shaji
2025-09-24 10:36 ` [pve-devel] [PATCH pve_flutter_frontend 4/4] chore: add upper bound flutter constraint and update dart sdk constraint Shan Shaji
2025-09-26 9:25 ` Dominik Csapak
2025-09-26 9:25 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f48a3b2f-67ae-43d5-affe-720290319026@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.