From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 widget-toolkit 1/2] repo view: replace non-clickable checkbox with icons
Date: Fri, 27 Jan 2023 12:16:28 +0100 [thread overview]
Message-ID: <f2825c33-9564-59a9-e7a9-f3ca2bc57db6@proxmox.com> (raw)
In-Reply-To: <be1adcb3-27fc-c154-45de-68edbc8713c2@proxmox.com>
Thank you for your input!
On 1/27/23 12:09, Dominik Csapak wrote:
> i know i'm a bit late to the party, but couldn't we simply show nothing when a repo is not enabled?
> it's greyed-out anyway (though i'm not opposed to using the 'minus' icon here either)
>
I have considered this option as well. IMO having the minus makes lists a bit clearer where all entities are disabled - for repos, this is probably never the case, but it could be for Backup/Replication jobs. It's just my preference though, I have no hard feelings about it.
--
- Lukas
next prev parent reply other threads:[~2023-01-27 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 11:09 Dominik Csapak
2023-01-27 11:16 ` Lukas Wagner [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-26 10:47 [pve-devel] [PATCH v3 manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes " Lukas Wagner
2023-01-26 10:47 ` [pve-devel] [PATCH v3 widget-toolkit 1/2] repo view: replace non-clickable checkbox " Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2825c33-9564-59a9-e7a9-f3ca2bc57db6@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal