[pve-devel] applied: [PATCH v2 common] REST environment: warn helpers: also log messages to syslog

From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 common] REST environment: warn helpers: also log messages to syslog
Date: Mon, 11 Nov 2024 19:41:07 +0100	[thread overview]
Message-ID: <f20f8b31-1406-4d0f-895c-09d29c8d6cbb@proxmox.com> (raw)
In-Reply-To: <20240209141503.62402-1-f.ebner@proxmox.com>

Am 09.02.24 um 15:15 schrieb Fiona Ebner:
> for better visibility. When not in a task, warnings from these helpers
> are only logged to STDERR, which is particularly unhelpful in case of
> daemons. This is the main motivation behind this change.
> 
> For tasks, warnings from these helpers are already more visible on the
> UI side, but when looking at the syslog, one can only see the warning
> count from the task right now, not the actual messages. This is
> another reason in favor of the change.
> 
> Reported-by: Friedrich Weber <f.weber@proxmox.com>
> Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> 
> Changes in v2:
>     * Go with the approach suggested by Thomas.
> 
>  src/PVE/RESTEnvironment.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
>

Albeit I'm not 100% sure how this will work out, my gut is not always right,
and it still seems more than sensible enough to try, so:

applied, thanks!

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel