From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pbs-devel] [RFC proxmox 1/5] time: add test for leap second parsing/converting
Date: Tue, 15 Sep 2020 13:35:42 +0200 [thread overview]
Message-ID: <f14f54c7-1eee-9094-688f-15dcee7880a5@proxmox.com> (raw)
In-Reply-To: <20200915102054.2866527-2-f.gruenbichler@proxmox.com>
On 9/15/20 12:20 PM, Fabian Grünbichler wrote:
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>
> Notes:
> test fails, fixed by next patch
>
off-topic, you and Dominik use this pattern to introduce test failure before
fixing it quite a bit, and I dislike it quite a bit.
Either just do the fix and the test in one patch, or re-order this so that
the fix comes first, then the previously failing test if you really think
it is semantically separate and needs to be a separate test...
We're all developers with at least a basic git experience, if one wants to
still check the prev. failure of the test anybody should be able to do that.
I do not want the build to fail at any commit.
next prev parent reply other threads:[~2020-09-15 11:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 10:20 [pbs-devel] [PATCH proxmox 0/5] time conversion tests and fixes Fabian Grünbichler
2020-09-15 10:20 ` [pbs-devel] [RFC proxmox 1/5] time: add test for leap second parsing/converting Fabian Grünbichler
2020-09-15 11:35 ` Thomas Lamprecht [this message]
2020-09-15 10:20 ` [pbs-devel] [RFC proxmox 2/5] time: allow leap seconds when parsing RFC3339 Fabian Grünbichler
2020-09-15 10:20 ` [pbs-devel] [PATCH proxmox 3/5] time: add tests for RFC3339 corner cases Fabian Grünbichler
2020-09-15 10:20 ` [pbs-devel] [PATCH proxmox 4/5] time/rfc3339: add leading zeroes for years < 1000 Fabian Grünbichler
2020-09-15 10:20 ` [pbs-devel] [PATCH proxmox 5/5] time: add tests for gmtime range Fabian Grünbichler
2020-09-15 11:48 ` [pbs-devel] applied: [PATCH proxmox 0/5] time conversion tests and fixes Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f14f54c7-1eee-9094-688f-15dcee7880a5@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal