From: Noel Ullreich <n.ullreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH pve-manager, proxmox-widget-toolkit v2 0/2] fix 4551: ui: translate byte units in web interface
Date: Mon, 22 May 2023 11:08:09 +0200 [thread overview]
Message-ID: <f11ca29f-2fd9-b905-ca8b-318b5c8dd488@proxmox.com> (raw)
In-Reply-To: <20230406113806.52027-1-n.ullreich@proxmox.com>
Ping. Still applies
On 06-04-2023 13:38, Noel Ullreich wrote:
> Since other languages translate byte units (such as 'GiB') or write them
> in their own script, this patch series wraps byte units in the `gettext`
> function, allowing them to be translated.
>
> ---
> changes from v1:
> * improved commit messages
> * put hardcoded byte unit strings in a template string
>
> Noel Ullreich (1):
> fix #4551: ui: use gettext on hardcoded byte units
> fix #4551: ui: translate byte unit in `format_size`
>
> www/manager6/ceph/OSD.js | 4 ++--
> www/manager6/form/DiskStorageSelector.js | 2 +-
> www/manager6/lxc/MPResize.js | 2 +-
> www/manager6/qemu/HDResize.js | 2 +-
> src/Utils.js | 14 ++++++++------
> 5 files changed, 13 insertions(+), 11 deletions(-)
>
prev parent reply other threads:[~2023-05-22 9:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 11:38 Noel Ullreich
2023-04-06 11:38 ` [pve-devel] [PATCH proxmox-widget-toolkit v2 1/1] fix #4551: ui: use gettext on hardcoded byte units Noel Ullreich
2023-06-01 14:14 ` Thomas Lamprecht
2023-04-06 11:38 ` [pve-devel] [PATCH proxmox-widget-toolkit v2 1/1] fix 4551: ui: translate byte unit in `format_size` Noel Ullreich
2023-06-01 14:16 ` [pve-devel] applied: " Thomas Lamprecht
2023-05-22 9:08 ` Noel Ullreich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f11ca29f-2fd9-b905-ca8b-318b5c8dd488@proxmox.com \
--to=n.ullreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal