Re: [pbs-devel] [PATCH v2 proxmox-backup 3/3] node: status: declutter kernel-version

[Gabriel Goller <g.goller@proxmox.com>]

Thanks for the review!

On 11/24/23 15:19, Lukas Wagner wrote:
> Hi, some comments inline :)
>
> On 11/24/23 13:02, Gabriel Goller wrote:
>>
>> diff --git a/www/panel/NodeInfo.js b/www/panel/NodeInfo.js
>> index 14f84a2e..b1e4ece2 100644
>> --- a/www/panel/NodeInfo.js
>> +++ b/www/panel/NodeInfo.js
>> @@ -140,11 +140,20 @@ Ext.define('PBS.NodeInfoPanel', {
>>           value: '',
>>       },
>>       {
>> -        itemId: 'kversion',
>>           colspan: 2,
>>           title: gettext('Kernel Version'),
>>           printBar: false,
>> -        textField: 'kversion',
>> +        // TODO: remove with next major and only use newish 
>> current-kernel textfield
>> +        multiField: true,
>> +        //textField: 'current-kernel',
> I guess this is not needed?
Not currently, as we return both the legacy *and* the new field. As we 
release the next
major version, we will remove the `multiField: true` and uncommment the 
`textField` property.
Same as it has been done in pve.
>
>> +        renderer: ({ data }) => {
>> +            if (!data['current-kernel']) {
>> +                return data.kversion;
>> +            }
>> +                let kernel = data['current-kernel'];
>> +                let buildDate = 
>> kernel.version.match(/\((.+)\)\s*$/)[1] ?? 'unknown';
>> +                return `${kernel.sysname} ${kernel.release} 
>> (${buildDate})`;
>
> Identation is off here, spaces instead of tabs+spaces
Right! Thanks for the heads up!
>
>> +        },
>>           value: '',
>>       },
>>       {
>