all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [PATCH v5 manager 2/3] ui: utils: add method to get VM data from resource store
Date: Sun, 18 Apr 2021 17:54:00 +0200	[thread overview]
Message-ID: <f093c698-173d-a256-cdcd-5ecc2755ded5@proxmox.com> (raw)
In-Reply-To: <20210215152647.7328-3-a.lauterer@proxmox.com>

On 15.02.21 16:26, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> v3 -> v4i -> v5: rebased
> v2 -> v3: nothing changed
> v1 -> v2: fixed linter errors
> 
> 
>  www/manager6/Utils.js | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
> index 7a1a7fb6..a298aac0 100644
> --- a/www/manager6/Utils.js
> +++ b/www/manager6/Utils.js
> @@ -1833,4 +1833,17 @@ Ext.define('PVE.Utils', {
>  	});
>      },
>  
> +    getNodeVMs: function(nodename) {
> +	let rstore = PVE.data.ResourceStore;
> +	let vms = {};
> +	rstore.data.items.forEach((item) => {

we normally use 'rstore' for a remote store, so I dislike the use when talking about
the in-memory ResourceStore as it's confusing.

FIY: In JS arrow functions the parenthesis can be dropped if there's only on parameter

And it seems like what you actually want is a .filter

let guests = rstore.data.items.filter(item => item.id.startsWith('qemu/') && item.data.node === nodename);

Maybe future proof this and allow to add the type, as we want the feature this
is made for also for CTs.

The whole thing could be reduced a bit with combinators, like (untested):

// type can be 'qemu', 'lxc' or left-out (for both)
// returns an Object with `vmid => guest-data` entries
getNodeGuests: function(nodename, type) {
    return PVE.data.ResourceStore.data
        .items
        .filter(item => (type && item.id.startsWith(`${type}/`)) && item.data.node === nodename)
        .reduce((acc, item) => acc[item.data.vmid] = item.data, {});
}

> +	    if (!item.id.startsWith('qemu/')) { return; }
> +	    let vmdata = item.data;
> +	    if (vmdata.node !== nodename) { return; }

Please avoid squishing early return ifs to one line. If that would be actually required
(see above for a general shorter approach), then it'd be nicer to write it as:

if (!item.id.startsWith('qemu/') || item.data.node !== nodename) {
    return;
}

> +
> +	    vms[vmdata.vmid] = vmdata;
> +	});
> +	return vms;
> +    },
> +
>  });
> 





  reply	other threads:[~2021-04-18 15:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-15 15:26 [pve-devel] [PATCH v5 series 0/3] Add GUI for disk reassignment Aaron Lauterer
2021-02-15 15:26 ` [pve-devel] [PATCH v5 widget-toolkit 1/3] window/edit: add option to disable reset button Aaron Lauterer
2021-04-13  7:08   ` [pve-devel] applied: " Thomas Lamprecht
2021-02-15 15:26 ` [pve-devel] [PATCH v5 manager 2/3] ui: utils: add method to get VM data from resource store Aaron Lauterer
2021-04-18 15:54   ` Thomas Lamprecht [this message]
2021-02-15 15:26 ` [pve-devel] [PATCH v5 manager 3/3] ui: qemu: Add disk reassign dialog Aaron Lauterer
2021-04-18 15:57   ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f093c698-173d-a256-cdcd-5ecc2755ded5@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal