all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Duerr <h.duerr@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [PATCH ha-manager] resources: Expand max_restart option
Date: Mon, 2 Mar 2026 14:00:20 +0100	[thread overview]
Message-ID: <f09183bc-d257-4566-8a67-c9b9053eb6b4@proxmox.com> (raw)
In-Reply-To: <20260302122831.319795-1-m.sandoval@proxmox.com>


On 3/2/26 1:28 PM, Maximiliano Sandoval wrote:
> When read next to `max_relocate` it is not clear which happens first
> after a service fails to start.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>
> When writting I initially had "When reached, the service will be attempted to be
> relocated" since it was clear it had to be on a "node" but as per HA rules not
> all of them might be eligible or some of them might already have reached the
> max_restart limit.
>
>   src/PVE/HA/Resources.pm | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/HA/Resources.pm b/src/PVE/HA/Resources.pm
> index 68d9d16..66dd7b4 100644
> --- a/src/PVE/HA/Resources.pm
> +++ b/src/PVE/HA/Resources.pm
> @@ -73,7 +73,8 @@ EODESC
>           },
>           max_restart => {
>               description => "Maximal number of tries to restart the service on"
> -                . " a node after its start failed.",
> +                . " a node after its start failed. When reached, the service will be attempted to"
> +                . " be relocated on an eligible node.",
The phrasing is a bit too complicated, would the following make sense?
`When reached, the HA manager will try to move the service to another 
eligible node.`
>               type => 'integer',
>               optional => 1,
>               default => 1,




  parent reply	other threads:[~2026-03-02 12:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 12:28 Maximiliano Sandoval
2026-03-02 12:39 ` Daniel Kral
2026-03-02 13:00 ` Hannes Duerr [this message]
2026-03-02 13:20   ` Maximiliano Sandoval
2026-03-03 13:23 ` superseded: " Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f09183bc-d257-4566-8a67-c9b9053eb6b4@proxmox.com \
    --to=h.duerr@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal