From: Gabriel Goller <g.goller@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-container 2/2] fix #5339: api: lxc: ip: add 'all' option so that all addresses can be returned.
Date: Tue, 7 Jan 2025 15:28:40 +0100 [thread overview]
Message-ID: <epyvtskczrjkmxuwpvzxrubcc563u4kcjrdnc2jv6c63ebyaga@ejxtigqfj3bq> (raw)
In-Reply-To: <mailman.710.1713473387.450.pve-devel@lists.proxmox.com>
Hi Johannes,
I recently submitted a patch similar to this one
(https://lore.proxmox.com/pve-devel/20241210151130.321984-1-g.goller@proxmox.com/T/#ma90b76fb51c7b24b8a1eb6031fd874f481d8b4a8)
for a different feature and completely overlooked that this patch exists
already. In my opinion, we should continue the work on my more recent
patch, as I prefer to always return an array, rather than only doing so
when a specific property is passed. The reason for this is that when
returning a single IP, there is no clear way to choose the "correct" one
(and, in fact, there may not even be a "correct" one to choose).
Let me know what you think!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-01-07 14:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240418204933.58521-1-jcdra1@gmail.com>
2024-04-18 20:49 ` [pve-devel] [PATCH pve-container 1/2] api: lxc: add 'interfaces' endpoint to the index Johannes Cornelis Draaijer via pve-devel
2024-07-02 14:22 ` [pve-devel] applied: " Fabian Grünbichler
2024-04-18 20:49 ` [pve-devel] [PATCH pve-container 2/2] fix #5339: api: lxc: ip: add 'all' option so that all addresses can be returned Johannes Cornelis Draaijer via pve-devel
2024-07-02 14:29 ` Fabian Grünbichler
2024-07-05 7:45 ` Wolfgang Bumiller
2024-07-05 7:49 ` Fabian Grünbichler
2025-01-07 14:28 ` Gabriel Goller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=epyvtskczrjkmxuwpvzxrubcc563u4kcjrdnc2jv6c63ebyaga@ejxtigqfj3bq \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.