From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Sterz <s.sterz@proxmox.com>,
pbs-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH proxmox-backup v3 3/6] fix #3607: ui: add a separate notes view for longer markdown notes
Date: Wed, 23 Mar 2022 12:08:28 +0100 [thread overview]
Message-ID: <efc4e40b-555b-4677-3734-6ed6e2c369d8@proxmox.com> (raw)
In-Reply-To: <20220304113202.4137916-4-s.sterz@proxmox.com>
On 04.03.22 12:31, Stefan Sterz wrote:
> since markdown notes might be rather long, this commit adds a tab
> similar to pve's datacenter or node notes.
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> www/Makefile | 2 +
> www/NavigationTree.js | 6 ++
> www/NodeNotes.js | 22 +++++++
> www/panel/MarkdownNotes.js | 130 +++++++++++++++++++++++++++++++++++++
> 4 files changed, 160 insertions(+)
> create mode 100644 www/NodeNotes.js
> create mode 100644 www/panel/MarkdownNotes.js
>
> diff --git a/www/panel/MarkdownNotes.js b/www/panel/MarkdownNotes.js
> new file mode 100644
> index 00000000..6d601401
> --- /dev/null
> +++ b/www/panel/MarkdownNotes.js> @@ -0,0 +1,130 @@
> +Ext.define('PBS.panel.MarkdownNotes', {
> + extend: 'Ext.panel.Panel',
> + xtype: 'pbsMarkdownNotes',
> + mixins: ['Proxmox.Mixin.CBind'],
> +
why add this if we move a almost identical one to widget toolkit?
If there are some changes required that cannot be easily passed via a config, we should still
reuse most by extending the NotesView wtk component, and not panel.Panel
WARNING: multiple messages have this Message-ID
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Sterz <s.sterz@proxmox.com>,
pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [pve-devel] [PATCH proxmox-backup v3 3/6] fix #3607: ui: add a separate notes view for longer markdown notes
Date: Wed, 23 Mar 2022 12:08:28 +0100 [thread overview]
Message-ID: <efc4e40b-555b-4677-3734-6ed6e2c369d8@proxmox.com> (raw)
In-Reply-To: <20220304113202.4137916-4-s.sterz@proxmox.com>
On 04.03.22 12:31, Stefan Sterz wrote:
> since markdown notes might be rather long, this commit adds a tab
> similar to pve's datacenter or node notes.
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> www/Makefile | 2 +
> www/NavigationTree.js | 6 ++
> www/NodeNotes.js | 22 +++++++
> www/panel/MarkdownNotes.js | 130 +++++++++++++++++++++++++++++++++++++
> 4 files changed, 160 insertions(+)
> create mode 100644 www/NodeNotes.js
> create mode 100644 www/panel/MarkdownNotes.js
>
> diff --git a/www/panel/MarkdownNotes.js b/www/panel/MarkdownNotes.js
> new file mode 100644
> index 00000000..6d601401
> --- /dev/null
> +++ b/www/panel/MarkdownNotes.js> @@ -0,0 +1,130 @@
> +Ext.define('PBS.panel.MarkdownNotes', {
> + extend: 'Ext.panel.Panel',
> + xtype: 'pbsMarkdownNotes',
> + mixins: ['Proxmox.Mixin.CBind'],
> +
why add this if we move a almost identical one to widget toolkit?
If there are some changes required that cannot be easily passed via a config, we should still
reuse most by extending the NotesView wtk component, and not panel.Panel
next prev parent reply other threads:[~2022-03-23 11:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 11:31 [pve-devel] [PATCH SERIES v3 0/6] fix #3607: add notes to functionality in webui Stefan Sterz
2022-03-04 11:31 ` [pbs-devel] " Stefan Sterz
2022-03-04 11:31 ` [pve-devel] [PATCH proxmox-backup v3 1/6] fix #3067: api: add support for multi-line comments in node.cfg Stefan Sterz
2022-03-04 11:31 ` [pbs-devel] " Stefan Sterz
2022-03-23 8:15 ` [pve-devel] " Wolfgang Bumiller
2022-03-23 8:15 ` Wolfgang Bumiller
2022-03-23 9:53 ` [pve-devel] applied: " Thomas Lamprecht
2022-03-23 9:53 ` [pbs-devel] applied: " Thomas Lamprecht
2022-03-04 11:31 ` [pve-devel] [PATCH proxmox-backup v3 2/6] fix #3607: docs: add markdown primer from pve to pbs Stefan Sterz
2022-03-04 11:31 ` [pbs-devel] " Stefan Sterz
2022-03-04 11:31 ` [pve-devel] [PATCH proxmox-backup v3 3/6] fix #3607: ui: add a separate notes view for longer markdown notes Stefan Sterz
2022-03-04 11:31 ` [pbs-devel] " Stefan Sterz
2022-03-23 11:08 ` Thomas Lamprecht [this message]
2022-03-23 11:08 ` [pbs-devel] [pve-devel] " Thomas Lamprecht
2022-03-04 11:32 ` [pve-devel] [PATCH widget-toolkit v3 4/6] toolkit: add markdown based NotesView and NotesEdit Stefan Sterz
2022-03-04 11:32 ` [pbs-devel] " Stefan Sterz
2022-03-23 11:04 ` [pve-devel] " Thomas Lamprecht
2022-03-23 11:04 ` [pbs-devel] " Thomas Lamprecht
2022-03-04 11:32 ` [pve-devel] [PATCH proxmox-backup v3 5/6] fix #3607: ui: refactor notes by moving the panel/window to widget kit Stefan Sterz
2022-03-04 11:32 ` [pbs-devel] " Stefan Sterz
2022-03-23 11:09 ` [pve-devel] " Thomas Lamprecht
2022-03-23 11:09 ` [pbs-devel] " Thomas Lamprecht
2022-03-04 11:32 ` [pve-devel] [PATCH manager v3 6/6] ui: move NotesView panel and NotesEdit window " Stefan Sterz
2022-03-04 11:32 ` [pbs-devel] " Stefan Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efc4e40b-555b-4677-3734-6ed6e2c369d8@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.