From: Robert Obkircher <r.obkircher@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH v1 proxmox-backup 2/3] client: pxar: consistently ignore vanished files and warn about them
Date: Mon, 11 May 2026 10:27:37 +0200 [thread overview]
Message-ID: <efb73278-366d-4d92-b13a-e6f56509efe3@proxmox.com> (raw)
In-Reply-To: <04ffa1f8-fa3a-4751-928b-d542fc1c09bf@proxmox.com>
On 08.05.26 16:11, Christian Ebner wrote:
> On 5/8/26 4:01 PM, Robert Obkircher wrote:
>>
>> On 08.05.26 15:24, Christian Ebner wrote:
>>> [..]
>>>
>>> In that case could you include a patch to cleanup the (one) other
>>> implicit context creation?
>>
>> Which one? I don't see another one
>
> I was referring to:
>
> https://git.proxmox.com/?p=proxmox-backup.git;a=blob;f=pbs-client/src/pxar/create.rs;h=d18021c4c57620897c8a1122f521365f913573e9;hb=HEAD#l709
>
>
> Should be
>
> diff --git a/pbs-client/src/pxar/create.rs
> b/pbs-client/src/pxar/create.rs
> index d18021c4c..fe3f851f2 100644
> --- a/pbs-client/src/pxar/create.rs
> +++ b/pbs-client/src/pxar/create.rs
> @@ -707,7 +707,7 @@ impl Archiver {
> continue;
> }
> Err(err) => {
> - return Err(err).with_context(|| format!("stat
> failed on {full_path:?}"))
> + return Err(err).context(format!("stat failed on
> {full_path:?}"))
> }
> }
This patch already deletes that line.
next prev parent reply other threads:[~2026-05-11 8:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 11:49 [PATCH v1 proxmox-backup 0/3] improve fstatat error handling Robert Obkircher
2026-05-06 11:49 ` [PATCH v1 proxmox-backup 1/3] client: pxar: improve variable names Robert Obkircher
2026-05-07 8:38 ` Christian Ebner
2026-05-06 11:49 ` [PATCH v1 proxmox-backup 2/3] client: pxar: consistently ignore vanished files and warn about them Robert Obkircher
2026-05-07 8:38 ` Christian Ebner
2026-05-07 15:50 ` Robert Obkircher
2026-05-08 9:38 ` Christian Ebner
2026-05-08 11:40 ` Robert Obkircher
2026-05-08 13:26 ` Christian Ebner
2026-05-08 14:03 ` Robert Obkircher
2026-05-08 14:12 ` Christian Ebner
2026-05-11 8:27 ` Robert Obkircher [this message]
2026-05-11 8:42 ` Christian Ebner
2026-05-06 11:49 ` [PATCH v1 proxmox-backup 3/3] client: pxar: skip files on fstatat permission errors Robert Obkircher
2026-05-07 8:42 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efb73278-366d-4d92-b13a-e6f56509efe3@proxmox.com \
--to=r.obkircher@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.