Re: [PATCH v1 proxmox-backup 3/3] client: pxar: skip files on fstatat permission errors

[Christian Ebner <c.ebner@proxmox.com>]

On 5/6/26 1:49 PM, Robert Obkircher wrote:
> Log a warning instead of aborting the entire backup if fstatat returns
> a permission error. This is preferable when running backups without
> full knowledge or control over the contents [1]. It is also more
> consistent with how we treat EACCES when opening files.
> 
> Note that it was already possible to explicitly exclude such files[2].
> 
> [1] https://forum.proxmox.com/threads/bug-with-fuse-mounts.182315/

nit: can be more concise by using thread id only

https://forum.proxmox.com/threads/182315/

> [2] https://bugzilla.proxmox.com/show_bug.cgi?id=4380
> 
> Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
> ---
>   pbs-client/src/pxar/create.rs | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/pbs-client/src/pxar/create.rs b/pbs-client/src/pxar/create.rs
> index 47cbf50a8..c101415c1 100644
> --- a/pbs-client/src/pxar/create.rs
> +++ b/pbs-client/src/pxar/create.rs
> @@ -710,6 +710,11 @@ impl Archiver {
>                       warn!("warning: file vanished while reading directory: {full_path:?}");
>                       continue;
>                   }
> +                Err(Errno::EACCES) => {
> +                    // may happen for fuse mountpoints without allow_other or allow_root
> +                    warn!("failed to stat file: {full_path:?}: access denied");

nit: similar to comment on previous patch, this should combine the 
warning into a report_file_access_denied() or similar.

> +                    continue;
> +                }
>                   Err(Errno::ESTALE) => {
>                       self.report_stale_file_handle(Some(&full_path));
>                       continue;