From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH installer 0/4] tui, auto: re-use default zfs arc calculation from run env
Date: Fri, 4 Apr 2025 10:49:42 +0200 [thread overview]
Message-ID: <efaf96ad-18e5-4547-936a-edb9f1d09d37@proxmox.com> (raw)
In-Reply-To: <20250228094341.147783-1-c.heiss@proxmox.com>
Am 28.02.25 um 10:43 schrieb Christoph Heiss:
> As discovered during the PMG 8.2 release cycle and suggested by Thomas, unify
> the ZFS ARC maximum calculation between GUI and TUI.
>
> In short; this series exports the calculated default value for the ZFS ARC
> maximum size in the `run-env.json` file. In turn, this is read by common Rust
> and can be used from there in the TUI and auto-installer.
>
> Diffstat
> ========
>
> Christoph Heiss (4):
> run env: provide default ZFS ARC maximum size value
> tui: use default ZFS ARC maximum size from runtime enviroment
> auto: use default ZFS ARC maximum size from runtime enviroment
> gtk, tui: leave 1 GiB headroom for OS in ZFS ARC max size edit view
>
> Proxmox/Install/RunEnv.pm | 10 +++-
> proxinstall | 3 +-
> proxmox-auto-installer/src/utils.rs | 2 +-
> .../resources/parse_answer/disk_match.toml | 1 +
> .../parse_answer/disk_match_all.toml | 1 +
> .../parse_answer/disk_match_any.toml | 1 +
> .../tests/resources/parse_answer/zfs.toml | 1 +
> .../zfs_raid_level_uppercase.toml | 1 +
> .../tests/resources/run-env-info.json | 2 +-
> proxmox-installer-common/src/options.rs | 58 +------------------
> proxmox-installer-common/src/setup.rs | 3 +
> proxmox-tui-installer/src/views/bootdisk.rs | 48 ++++++---------
> test/zfs-arc-max.pl | 12 +---
> 13 files changed, 43 insertions(+), 100 deletions(-)
>
applied series, had to workaround the garbled diff from patch 3/4 due to mail length
limits, thanks!, luckily one can just edit the patch in .git/rebase-apply/0001 and
use git apply and git am --continue to fix this locally.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-04-04 8:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 9:43 [pve-devel] " Christoph Heiss
2025-02-28 9:43 ` [pve-devel] [PATCH installer 1/4] run env: provide default ZFS ARC maximum size value Christoph Heiss
2025-02-28 9:43 ` [pve-devel] [PATCH installer 2/4] tui: use default ZFS ARC maximum size from runtime enviroment Christoph Heiss
2025-02-28 9:43 ` [pve-devel] [PATCH installer 3/4] auto: " Christoph Heiss
2025-02-28 9:43 ` [pve-devel] [PATCH installer 4/4] gtk, tui: leave 1 GiB headroom for OS in ZFS ARC max size edit view Christoph Heiss
2025-04-04 8:49 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efaf96ad-18e5-4547-936a-edb9f1d09d37@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal