all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox] proxmox-router: Improve CLI text output when printing empty lists
@ 2025-01-22 13:14 Laurențiu Leahu-Vlăducu
  2025-01-24  8:26 ` Thomas Lamprecht
  0 siblings, 1 reply; 4+ messages in thread
From: Laurențiu Leahu-Vlăducu @ 2025-01-22 13:14 UTC (permalink / raw)
  To: pbs-devel

CLI tools that use '--output-format text' and print empty lists now
show a 'No results' message. Previously, this was sometimes confusing
because nothing was printed.

Signed-off-by: Laurențiu Leahu-Vlăducu <l.leahu-vladucu@proxmox.com>
---
 proxmox-router/src/cli/text_table.rs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/proxmox-router/src/cli/text_table.rs b/proxmox-router/src/cli/text_table.rs
index 34173b4d..6109d36f 100644
--- a/proxmox-router/src/cli/text_table.rs
+++ b/proxmox-router/src/cli/text_table.rs
@@ -788,7 +788,7 @@ fn extract_one_of_variant_properties(
 
 /// Format data using TableFormatOptions
 pub fn value_to_text<W: Write>(
-    output: W,
+    mut output: W,
     data: &mut Value,
     schema: &Schema,
     options: &TableFormatOptions,
@@ -820,6 +820,7 @@ pub fn value_to_text<W: Write>(
                 None => bail!("got unexpected data (expected array)."),
             };
             if list.is_empty() {
+                output.write_all(b"No results\n")?;
                 return Ok(());
             }
 
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-01-24  9:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-22 13:14 [pbs-devel] [PATCH proxmox] proxmox-router: Improve CLI text output when printing empty lists Laurențiu Leahu-Vlăducu
2025-01-24  8:26 ` Thomas Lamprecht
2025-01-24  8:58   ` Laurențiu Leahu-Vlăducu
2025-01-24  9:13     ` Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal