From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Hannes Duerr <h.duerr@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server v2 1/2] fix #5363: cloudinit: make creation of scsi cloudinit discs possible again
Date: Wed, 10 Apr 2024 15:42:47 +0200 [thread overview]
Message-ID: <ef568897-13ae-4814-a39d-8b2eb206872c@proxmox.com> (raw)
In-Reply-To: <20240410111730.189254-1-h.duerr@proxmox.com>
Am 10/04/2024 um 13:17 schrieb Hannes Duerr:
> Upon obtaining the device type, a check is performed to determine if it
> is a CD drive. It is important to note that Cloudinit drives are always
> assigned as CD drives. If the drive has not yet been allocated, the test
> will fail due to the unset cd attribute.
> To avoid this, an explicit check is now performed to determine if it is
> a Cloudinit drive that has not yet been assigned.
>
> The mentioned error was introduced by this patch:
> https://lists.proxmox.com/pipermail/pve-devel/2024-January/061311.html
>
> Signed-off-by: Hannes Duerr <h.duerr@proxmox.com>
> ---
> Changes since v1:
> - fixed rephrased commit message
> - added reference to the commit which introduced the bug
>
> PVE/QemuServer/Drive.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied both patches, thanks!
prev parent reply other threads:[~2024-04-10 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 11:17 [pve-devel] " Hannes Duerr
2024-04-10 11:17 ` [pve-devel] [PATCH qemu-server v2 2/2] drive: improve readability to get_scsi_device_type Hannes Duerr
2024-04-10 13:42 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef568897-13ae-4814-a39d-8b2eb206872c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=h.duerr@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.