Re: [pve-devel] [PATCH edk2-firmware v2] update to edk2-stable202308

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 30/08/2023 um 17:50 schrieb Stefan Hanreich:
> * Removed 0001-OvmfPkg-PlatformInitLib-limit-phys-bits-to-46.patch
>   since it has been included upstream since commit c1e85376 [1].
> 
> * Updated the patch
>   Revert-ArmVirtPkg-make-EFI_LOADER_DATA-non-executabl so it applies
>   again.
> 
> * had to increase FD_SIZE to 4M for the x64 build as otherwise the
>   package wouldn't build due to the size of the resulting image

I mean new versions are great and what not, but is there a reason why you
send this update now? Maybe fix some issue our users face? If so, it'd be
great if you could record that here.

> 
> [1] https://github.com/tianocore/edk2/commit/c1e853769046b322690ad336fdb98966757e7414
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> 
> Changes from v1 -> v2:
> * fixed metadata in ArmVirtPkg patch
> 
> Wasn't able to build this package without setting FD_SIZE to 4M, not
> sure if this is due to my failure or if the image just got bigger with
> the new changes.

isn't this breaking live-migration and snapshot rollback compat though
for old machines using that?

For new ones we only use 4 MB images anyway, so if, I'd rather move a
existing build for 2MB images in some pve-edk2-firmware-legacy package
for backward compat and then drop building those variants here completely.

Would be great if you could check qemu-server history for when the 2MB
SMM ones where used, if at all, could help deciding things.

> 
> Due to CRLF shenanigans I have made this commit available via my repos
> as well - you can find it under staff/s.hanreich/pve-edk2-firmware on
> the branch 2023-08.
> 
> Still not sure if the line endings are 100% correct since I have
> warnings about EOL and trailing spaces, but I think they are because
> of gits CRLF handling.
> 
>  debian/changelog                              |  6 +++
>  ...latformInitLib-limit-phys-bits-to-46.patch | 43 -------------------
>  ...g-make-EFI_LOADER_DATA-non-executabl.patch |  6 +--
>  debian/patches/series                         |  1 -
>  debian/rules                                  |  3 +-
>  edk2                                          |  2 +-
>  6 files changed, 11 insertions(+), 50 deletions(-)
>  delete mode 100644 debian/patches/0001-OvmfPkg-PlatformInitLib-limit-phys-bits-to-46.patch
> 
> diff --git a/debian/changelog b/debian/changelog
> index 4d0ac21..dd61c6f 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -1,3 +1,9 @@
> +pve-edk2-firmware (3.20230826-1) bookworm; urgency=medium
> +
> +  * update sources to upstream edk2-stable202308 tag
> +
> + -- Proxmox Support Team <support@proxmox.com>  Tue, 29 Aug 2023 13:58:15 +0200
> +

bumps should be separate commits and restricted to plain version and
changelog metadata, like here it'd only touch d/changelog.

Also, it's most of the time best to let the release team handle the
bumps.