all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] superseded: [PATCH storage 1/2] lvm plugin: properly handle qcow2 format when querying volume size info
Date: Fri, 18 Jul 2025 12:21:50 +0200	[thread overview]
Message-ID: <eee17de3-e1e0-41ac-acde-88c857f3c94a@proxmox.com> (raw)
In-Reply-To: <20250718101223.68650-1-f.ebner@proxmox.com>

Sorry, for the noise. I sent a v2 with better meta info:

https://lore.proxmox.com/pve-devel/20250718102023.70591-1-f.ebner@proxmox.com/T/#u

Am 18.07.25 um 12:12 PM schrieb Fiona Ebner:
> Fixes: eda88c9 ("lvmplugin: add qcow2 snapshot")
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  src/PVE/Storage/LVMPlugin.pm | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
> index 7044c4f..6d57097 100644
> --- a/src/PVE/Storage/LVMPlugin.pm
> +++ b/src/PVE/Storage/LVMPlugin.pm
> @@ -930,8 +930,12 @@ sub volume_resize {
>  
>  sub volume_size_info {
>      my ($class, $scfg, $storeid, $volname, $timeout) = @_;
> +
> +    my ($format) = ($class->parse_volname($volname))[6];
>      my $path = $class->filesystem_path($scfg, $volname);
>  
> +    return PVE::Storage::Plugin::file_size_info($path, $timeout, $format) if $format eq 'qcow2';
> +
>      my $cmd = [
>          '/sbin/lvs',
>          '--separator',



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-07-18 10:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-18 10:12 [pve-devel] " Fiona Ebner
2025-07-18 10:12 ` [pve-devel] [PATCH storage 2/2] lvm plugin: list images: properly handle qcow2 format Fiona Ebner
2025-07-18 10:21 ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eee17de3-e1e0-41ac-acde-88c857f3c94a@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal