From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH docs] backup: warn that tar does not honor exclusion pattern with a trailing slash
Date: Mon, 7 Apr 2025 19:39:35 +0200 [thread overview]
Message-ID: <ee3bcefb-f206-421a-8ae9-50a5e96763e5@proxmox.com> (raw)
In-Reply-To: <20240531100753.40964-2-f.ebner@proxmox.com>
Am 31.05.24 um 12:07 schrieb Fiona Ebner:
> As reported in the community forum [0], for tar, an exclusion pattern
> with a trailing slash will not match a folder with that name. For
> rsync and proxmox-backup-client however, such a pattern will exclude
> a directory with that name, but not a file.
>
> rsync is used for 'suspend' mode backup and tar is used for all
> non-PBS backups to create the archive. So currently, in the presence
> of an exclusion pattern with a trailing slash, there is inconsistency
> between different backup modes (because for 'suspend' mode, rsync will
> already do the exclusion too) as well as between PBS and non-PBS
> backups.
>
> There doesn't seem to be a straight-forward way to align the behavior
> for tar with command-line options exactly. The trailing slash can't be
> removed from the pattern, because that would also match files.
> Matching with
>> some/pattern/*
>> some/pattern/.*
> rather than
>> some/pattern/
> gets pretty close, which was suggested by Dominik. Just the empty
> directory is still included.
>
> In any case, modifying current behavior would be a breaking change, so
> actually aligning the exclusion (more closely) is better done in the
> next major release.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> vzdump.adoc | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-04-07 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 10:07 [pve-devel] [PATCH container] " Fiona Ebner
2024-05-31 10:07 ` [pve-devel] [PATCH docs] " Fiona Ebner
2024-11-29 14:33 ` Fiona Ebner
2025-04-07 17:39 ` Thomas Lamprecht [this message]
2024-09-10 14:35 ` [pve-devel] applied: [PATCH container] " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee3bcefb-f206-421a-8ae9-50a5e96763e5@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal